Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library - Limit the number of cards displayed in the 'Recent' section #11438

Closed
pcenov opened this issue Oct 20, 2023 · 2 comments · Fixed by #11515
Closed

Library - Limit the number of cards displayed in the 'Recent' section #11438

pcenov opened this issue Oct 20, 2023 · 2 comments · Fixed by #11515
Assignees
@thanksameeelian
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend P1 - important Priority: High impact on UX
Milestone
Kolibri 0.16.0: B...

Comments

@pcenov
Copy link
Member

pcenov commented Oct 20, 2023 •
edited
Loading

Observed behavior

The 'Recent' section can get quite long - a 'View more' link is shown in Figma when there are more than 3 cards.

Steps to reproduce the issue

  1. Install the latest build from Fix up reactivity and display issues for remote libraries on LibraryPage and ExploreLibrariesPage #11419 and setup a full facility.
  2. Go to the Library page and view multiple resources.
  3. Observe the 'Recent' section.

More information

Recent.Section.mp4

Usage Details

Kolibri 0.16beta6
Ubuntu - Chrome, Firefox
@pcenov
Copy link
Member Author

pcenov commented Oct 20, 2023

@radinamatic

@marcellamaki marcellamaki added P1 - important Priority: High impact on UX APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend labels Oct 23, 2023
@thanksameeelian thanksameeelian self-assigned this Oct 24, 2023
@rtibbles
Copy link
Member

When fixing this issue, I would recommend using this composable to enforce a limit of one row of card display (or a minimum of three cards), and also to help make the cards smaller (they often display significantly larger than the channel card on the same page).

https://github.com/learningequality/kolibri/blob/release-v0.16.x/kolibri/plugins/learn/assets/src/composables/useCardLayoutSpan.js

@thanksameeelian thanksameeelian mentioned this issue Nov 9, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thanksameeelian thanksameeelian

Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend P1 - important Priority: High impact on UX
Projects
None yet
Milestone
Kolibri 0.16.0: Bugs and Regressions
Development

Successfully merging a pull request may close this issue.

limit number of cards visible in "Recent" thanksameeelian/kolibri
4 participants
@rtibbles @marcellamaki @thanksameeelian @pcenov