Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace KResponsiveWindow mixin by useKResponsiveWindow composable - User Profile plugin #11333

Closed
Tracked by #11321
MisRob opened this issue Sep 29, 2023 · 3 comments
Closed
Tracked by #11321

Replace KResponsiveWindow mixin by useKResponsiveWindow composable - User Profile plugin #11333

MisRob opened this issue Sep 29, 2023 · 3 comments
Assignees
@thesujai
Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have

Comments

@MisRob
Copy link
Member

MisRob commented Sep 29, 2023

This is one of the issues whose common goal is to gradually replace KResponsiveWindow mixin by useKResponsiveWindow composable.

First, see #11321 for detailed instructions and acceptance criteria common to all issues.

Then, replace KResponsiveWindow mixin by useKResponsiveWindow composable in all .vue files of the User Profile plugin (kolibri/plugins/user_profile)
@MisRob MisRob added P2 - normal Priority: Nice to have DEV: frontend help wanted Open source contributors welcome good first issue Self-contained, straightforward, low-complexity labels Sep 29, 2023
@MisRob MisRob mentioned this issue Sep 29, 2023
Closed
4 tasks
@thesujai
Copy link
Contributor

thesujai commented Oct 2, 2023

@MisRob Please, assign this to me

@MisRob
Copy link
Member Author

MisRob commented Oct 2, 2023 •
edited
Loading

Hi @thesujai, assigning you, thank you. Note that even though we will review your pull request, it might take some time to merge it because we have some important fixes in progress for useKResponsiveWindow (learningequality/kolibri-design-system#453) that we might need to finish at first before we use the composable more widely. It's not a blocker for working on this though.

This was referenced Oct 2, 2023
Closed
Merged
@MisRob
Copy link
Member Author

MisRob commented Oct 26, 2023

Closed by #11358

@MisRob MisRob closed this as completed Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thesujai thesujai

Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MisRob @thesujai