-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace KResponsiveWindow mixin by useKResponsiveWindow composable - User Auth plugin #11332
Comments
I would like to work on it. |
Hi @ShivangRawat30, great, thanks. Assigning you. I can also see you volunteered for other issues from this group. Kindly request, please ask for an assignment of a reasonable amount of issues. Each one of these will take some time as you will need to find places to test etc. As soon as you complete your assigned issues, you're welcome to ask for more. If you decide not to work on some of them, but rather worked on something else, please let us know and we can re-assign you. Thank you. |
@ShivangRawat30 Note that even though we will review your pull request, it might take some time to merge it because we have some important fixes in progress for useKResponsiveWindow (learningequality/kolibri-design-system#453) that we might need to finish at first before we use the composable more widely. It's not a blocker for working on this though. |
@MisRob I didn't find any |
Hi @ShivangRawat30, can you try to search for |
I think I included only plugins that use it in the issues, but it's possible I made mistake and included some that don't. Let us know if you've found anything. |
@ShivangRawat30 No problem at all :)! |
@MisRob I attempted to replace |
@ShivangRawat30 I see, in that case, you can just remove the obsolete import and then, if there are no more occurrences of the mixin in the user auth plugin, that would close this issue. |
Fixed in #11354 (note, this was a low risk change, so I merged this to release-v0.16.x, rather than retarget to develop). |
This is one of the issues whose common goal is to gradually replace
KResponsiveWindow
mixin byuseKResponsiveWindow
composable.First, see #11321 for detailed instructions and acceptance criteria common to all issues.
Then, replace
KResponsiveWindow
mixin byuseKResponsiveWindow
composable in all .vue files of the User Auth plugin (kolibri/plugins/user_auth)The text was updated successfully, but these errors were encountered: