Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace KResponsiveWindow mixin by useKResponsiveWindow composable - User Auth plugin #11332

Closed
Tracked by #11321
MisRob opened this issue Sep 29, 2023 · 11 comments
Closed
Tracked by #11321
Assignees
Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have

Comments

@MisRob
Copy link
Member

MisRob commented Sep 29, 2023

This is one of the issues whose common goal is to gradually replace KResponsiveWindow mixin by useKResponsiveWindow composable.

First, see #11321 for detailed instructions and acceptance criteria common to all issues.

Then, replace KResponsiveWindow mixin by useKResponsiveWindow composable in all .vue files of the User Auth plugin (kolibri/plugins/user_auth)

@MisRob MisRob added P2 - normal Priority: Nice to have DEV: frontend help wanted Open source contributors welcome good first issue Self-contained, straightforward, low-complexity labels Sep 29, 2023
@ShivangRawat30
Copy link
Contributor

I would like to work on it.

@MisRob
Copy link
Member Author

MisRob commented Oct 2, 2023

Hi @ShivangRawat30, great, thanks. Assigning you.

I can also see you volunteered for other issues from this group. Kindly request, please ask for an assignment of a reasonable amount of issues. Each one of these will take some time as you will need to find places to test etc. As soon as you complete your assigned issues, you're welcome to ask for more. If you decide not to work on some of them, but rather worked on something else, please let us know and we can re-assign you. Thank you.

@MisRob
Copy link
Member Author

MisRob commented Oct 2, 2023

@ShivangRawat30 Note that even though we will review your pull request, it might take some time to merge it because we have some important fixes in progress for useKResponsiveWindow (learningequality/kolibri-design-system#453) that we might need to finish at first before we use the composable more widely. It's not a blocker for working on this though.

@ShivangRawat30
Copy link
Contributor

@MisRob I didn't find any KResponsiveWindowMixins in kolibri/plugins/user_auth, is that the correct directory ?

@MisRob
Copy link
Member Author

MisRob commented Oct 4, 2023

Hi @ShivangRawat30, can you try to search for responsiveWindowMixin? See the note in the parent issue #11321 about imports.

@MisRob
Copy link
Member Author

MisRob commented Oct 4, 2023

I think I included only plugins that use it in the issues, but it's possible I made mistake and included some that don't. Let us know if you've found anything.

@ShivangRawat30
Copy link
Contributor

@MisRob My apologies for the misunderstanding. I've now realized the details of the responsiveWindowMixin in issue #11321, and I'm ready to begin working on it.

@MisRob
Copy link
Member Author

MisRob commented Oct 4, 2023

@ShivangRawat30 No problem at all :)!

@ShivangRawat30
Copy link
Contributor

@MisRob I attempted to replace KResponsiveWindow with useKResponsiveWindow, but upon closer inspection, I discovered that KResponsiveWindow was imported in the file even though it wasn't being used.

@MisRob
Copy link
Member Author

MisRob commented Oct 5, 2023

@ShivangRawat30 I see, in that case, you can just remove the obsolete import and then, if there are no more occurrences of the mixin in the user auth plugin, that would close this issue.

@rtibbles
Copy link
Member

rtibbles commented Oct 8, 2023

Fixed in #11354 (note, this was a low risk change, so I merged this to release-v0.16.x, rather than retarget to develop).

@rtibbles rtibbles closed this as completed Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have
Projects
None yet
Development

No branches or pull requests

3 participants