Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace KResponsiveWindow mixin by useKResponsiveWindow composable - Perseus Viewer plugin #11329

Closed
Tracked by #11321
MisRob opened this issue Sep 29, 2023 · 4 comments
Closed
Tracked by #11321

Replace KResponsiveWindow mixin by useKResponsiveWindow composable - Perseus Viewer plugin #11329

MisRob opened this issue Sep 29, 2023 · 4 comments
Assignees
@ShivangRawat30
Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have

Comments

@MisRob
Copy link
Member

MisRob commented Sep 29, 2023

This is one of the issues whose common goal is to gradually replace KResponsiveWindow mixin by useKResponsiveWindow composable.

First, see #11321 for detailed instructions and acceptance criteria common to all issues.

Then, replace KResponsiveWindow mixin by useKResponsiveWindow composable in all .vue files of the Perseus Viewer plugin plugin (kolibri/plugins/perseus_viewer)
@MisRob MisRob added P2 - normal Priority: Nice to have DEV: frontend help wanted Open source contributors welcome good first issue Self-contained, straightforward, low-complexity labels Sep 29, 2023
@MisRob MisRob mentioned this issue Sep 29, 2023
Closed
4 tasks
@ShivangRawat30
Copy link
Contributor

I would like to work on it.

@MisRob
Copy link
Member Author

MisRob commented Oct 2, 2023

@ShivangRawat30 I already assigned you some other issues so I'll leave this open for other contributors. You're welcome to remind yourself here again as soon as you've finished them (explained more in one of the comments I left for you).

@ShivangRawat30
Copy link
Contributor

I've opened a PR related to the other assigned issues, can I work on this issue ?

@MisRob
Copy link
Member Author

MisRob commented Oct 10, 2023

Sure @ShivangRawat30, thank you!

@ShivangRawat30 ShivangRawat30 mentioned this issue Oct 14, 2023
Merged
9 tasks
@MisRob MisRob closed this as completed Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShivangRawat30 ShivangRawat30

Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MisRob @ShivangRawat30