Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloads are not properly loaded on TopicsPage and TopicsContentPage #11239

Closed
rtibbles opened this issue Sep 14, 2023 · 0 comments · Fixed by #11391
Closed

Downloads are not properly loaded on TopicsPage and TopicsContentPage #11239

rtibbles opened this issue Sep 14, 2023 · 0 comments · Fixed by #11391
Assignees
Labels
P0 - critical Priority: Release blocker or regression

Comments

@rtibbles
Copy link
Member

Observed behavior

We currently load the first page of download requests

There's no guarantee (if someone has a lot of download requests) that the currently displayed resource(s) will be included in those first 100

Expected behavior

For the TopicsPage - download filtered by the displayed resource ids.
Also, when doing any 'load more' behaviour, ensure that additional download requests are loaded for the newly fetched resources.

For the TopicsContentPage - download filtered by the displayed resource id.

In both cases, we should show a loading state in place of the add/remove download button until the data has been loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant