Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported facility - Can't access the pages in the Coach plugin #10835

Closed
pcenov opened this issue Jun 12, 2023 · 5 comments · Fixed by #10813
Closed

Imported facility - Can't access the pages in the Coach plugin #10835

pcenov opened this issue Jun 12, 2023 · 5 comments · Fixed by #10813

Comments

@pcenov
Copy link
Member

pcenov commented Jun 12, 2023

Observed behavior

While regression testing for #10812 I noticed that after importing a facility I can't access any of the pages in the Coach plugin. This happens after I sign out from my main facility and then sign in to the imported facility as a super admin. Seems that this is a side effect from the changes made in #10768.
The following error is shown in the console: Error: Missing required 'facilityId' argument

Expected behavior

It should be possible to access the Coach plugin of an imported facility as a super admin.

Steps to reproduce the issue

  1. Install the latest develop build
  2. Setup a multifacility device
  3. Sign in to an imported facility and attempt to access any of the pages in the Coach plugin.

Video

2023-06-12_16-17-31.mp4

Usage Details

Ubuntu 22 - Chrome, Firefox

@pcenov
Copy link
Member Author

pcenov commented Jun 12, 2023

@thanksameeelian @radinamatic

@rtibbles
Copy link
Member

This seems to be a duplicate of #10811?

@thanksameeelian
Copy link
Contributor

thanksameeelian commented Jun 12, 2023

agree with @rtibbles - there is potentially already an existing fix for this (if it is a duplicate) here, it's just waiting for the changes in #10812 to be approved by QA & merged before we apply it, in an attempt to avoid further merge conflicts for that contributor.

@pcenov
Copy link
Member Author

pcenov commented Jun 12, 2023

No probs, closing this one - seemed like a different case to me as #10811 was reported only for a Coach user. :)

@pcenov pcenov closed this as completed Jun 12, 2023
@thanksameeelian
Copy link
Contributor

@pcenov i do think it's worth double-checking that this specific case is covered by the fix mentioned above once it comes up for review (hopefully today), but i believe the case you reported should be covered by the code change that PR is introducing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants