-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coach: multi-facility user briefly sees 1st facility's class list when navigating to a class in 2nd facility #10714
Comments
@thanksameeelian - just curious if you tried this out with a throttled browser speed to see if the scenario you describe
might be happening for users who are on a slower system? If so, we might want to bump up the priority here a little bit If you haven't used throttling for testing performance before, you can update it here in Chrome. |
@marcellamaki thanks for this!! the problem is much more evident when i intentionally throttle the browser speed. in all these cases i'm a multi-facility user. navigating from a link on my imported facility's "All classes" page, i was shown my default facility's "all classes" page for long enough that i could click on a class there and cause a little bit of additional chaos: can-click-in-interim.movother things that throttling revealed in the same area (but may be solved by already-ongoing work on loading state?): when i try to navigate to my default facility, which only has one class, on slow 3G i actually see two different views before the one we intend, as we should be navigating directly to the class home if there is only one class. both an empty "no classes" page & an "all classes" page containing 1 class are visible for long enough periods of time that i could click something on the temporarily-rendered page throttled-default-facility.movin my imported facility, i have multiple classes, and am shown "no classes" before reaching the intended "All classes" page. throttled-multfacility.mov |
so the short answer is yes! :) |
@radinamatic if this issue replicates please assign it to me and I'll resolve it directly - but I am pretty sure I fixed this in f5153e9 in #10455 🤞🏻 |
@radinamatic I confirm that this is fixed now: 2023-06-13_14-30-42.mp4 |
Excellent, thank you! 💯 Closing as fixed! 💥 |
Observed behavior
As a multi-facility admin user, when I navigate to the
Coach
>Class home
page and am redirected to the list of my facilities, select the second facility in the list, and select any class, there is a split-second flash of the other facility's (my default facility) class list, which renders in the view before I am successfully navigated to the class initially selected.No matter the order in which I select them, when I click on Class2A in Mr. Tibbles' House of Phun, the brief flash of my other facility's classes is (usually) visible to the naked eye, and clicking on Class1B leads to the same experience but also an error in the console. I don't experience this when selecting classes from my default facility.
seeing-other-facilitys-classes.mov
now in slow motion!
Errors and logs
Expected behavior
Clicking on a link to a class within a specific facility will navigate straight to that class, without any other views rendering
User-facing consequences
currently appears cosmetic, as user is ultimately navigated to the correct place.
a potential scenario: a user's machine & browser are running slowly and the short flash of the other facility's classes is visible for longer than in the screen recording, and during the interim the user clicks in the same spot their cursor already is, but since the link below their cursor had changed they'll potentially be redirected to the page for a class they didn't intend to select.
Steps to reproduce
Coach
>Class home
and select user's non-default facility upon redirect to theFacilities
pageNote: reported console error may be specific to facility & class selected in screen recording (Mr. Tibbles' House of Phun - Class1B), but the overall behavior described was seen for all classes in non-default facility, and not observed when intentionally navigating to classes within default facility.
Context
Chrome -
develop
branch of KolibriThe text was updated successfully, but these errors were encountered: