Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coach: multi-facility user briefly sees 1st facility's class list when navigating to a class in 2nd facility #10714

Closed
thanksameeelian opened this issue May 17, 2023 · 6 comments
Assignees
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.)

Comments

@thanksameeelian
Copy link
Contributor

thanksameeelian commented May 17, 2023

Observed behavior

As a multi-facility admin user, when I navigate to the Coach > Class home page and am redirected to the list of my facilities, select the second facility in the list, and select any class, there is a split-second flash of the other facility's (my default facility) class list, which renders in the view before I am successfully navigated to the class initially selected.

No matter the order in which I select them, when I click on Class2A in Mr. Tibbles' House of Phun, the brief flash of my other facility's classes is (usually) visible to the naked eye, and clicking on Class1B leads to the same experience but also an error in the console. I don't experience this when selecting classes from my default facility.

seeing-other-facilitys-classes.mov

now in slow motion!
slo-mo

Errors and logs

image

Expected behavior

Clicking on a link to a class within a specific facility will navigate straight to that class, without any other views rendering

User-facing consequences

currently appears cosmetic, as user is ultimately navigated to the correct place.

a potential scenario: a user's machine & browser are running slowly and the short flash of the other facility's classes is visible for longer than in the screen recording, and during the interim the user clicks in the same spot their cursor already is, but since the link below their cursor had changed they'll potentially be redirected to the page for a class they didn't intend to select.

Steps to reproduce

  • user must be a multi-facility admin
  • it may be useful to record your screen, as the unexpected view of the other facility's classes may be visible only very briefly
  • navigate to Coach > Class home and select user's non-default facility upon redirect to the Facilities page
  • select a class from that facility
  • during navigation to that class's page, the view will momentarily change to reflect the list of classes from user's default facility before the intended view renders and user has been navigated to the initially-selected class's page.

Note: reported console error may be specific to facility & class selected in screen recording (Mr. Tibbles' House of Phun - Class1B), but the overall behavior described was seen for all classes in non-default facility, and not observed when intentionally navigating to classes within default facility.

Context

Chrome - develop branch of Kolibri

@thanksameeelian thanksameeelian added P3 - low Priority: Stretch goal APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) labels May 17, 2023
@thanksameeelian thanksameeelian changed the title multi-facility user briefly sees 1st facility's class list when navigating to a class in 2nd facility coach: multi-facility user briefly sees 1st facility's class list when navigating to a class in 2nd facility May 22, 2023
@marcellamaki
Copy link
Member

@thanksameeelian - just curious if you tried this out with a throttled browser speed to see if the scenario you describe

a user's machine & browser are running slowly and the short flash of the other facility's classes is visible for longer than in the screen recording,

might be happening for users who are on a slower system? If so, we might want to bump up the priority here a little bit

If you haven't used throttling for testing performance before, you can update it here in Chrome.
Screenshot 2023-05-22 at 3 30 59 PM
Screenshot 2023-05-22 at 3 31 06 PM

@thanksameeelian
Copy link
Contributor Author

@marcellamaki thanks for this!! the problem is much more evident when i intentionally throttle the browser speed. in all these cases i'm a multi-facility user.

navigating from a link on my imported facility's "All classes" page, i was shown my default facility's "all classes" page for long enough that i could click on a class there and cause a little bit of additional chaos:

can-click-in-interim.mov

other things that throttling revealed in the same area (but may be solved by already-ongoing work on loading state?):

when i try to navigate to my default facility, which only has one class, on slow 3G i actually see two different views before the one we intend, as we should be navigating directly to the class home if there is only one class. both an empty "no classes" page & an "all classes" page containing 1 class are visible for long enough periods of time that i could click something on the temporarily-rendered page

throttled-default-facility.mov

in my imported facility, i have multiple classes, and am shown "no classes" before reaching the intended "All classes" page.

throttled-multfacility.mov

@thanksameeelian
Copy link
Contributor Author

just curious if you tried this out with a throttled browser speed to see if the scenario you describe might be happening for users who are on a slower system? If so, we might want to bump up the priority here a little bit

so the short answer is yes! :)

@nucleogenesis
Copy link
Member

nucleogenesis commented Jun 7, 2023

@radinamatic if this issue replicates please assign it to me and I'll resolve it directly - but I am pretty sure I fixed this in f5153e9 in #10455 🤞🏻

@pcenov
Copy link
Member

pcenov commented Jun 13, 2023

@radinamatic I confirm that this is fixed now:

2023-06-13_14-30-42.mp4

@radinamatic
Copy link
Member

Excellent, thank you! 💯

Closing as fixed! 💥

@radinamatic radinamatic removed the TODO: needs QA re-review For stale issues that need to be revisited label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.)
Projects
None yet
Development

No branches or pull requests

6 participants