Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vendored ipaddress module when we drop Python 2.7 support #10363

Closed
Tracked by #10484
akolson opened this issue Mar 31, 2023 · 2 comments
Closed
Tracked by #10484

Remove vendored ipaddress module when we drop Python 2.7 support #10363

akolson opened this issue Mar 31, 2023 · 2 comments
Assignees
@rtibbles
Labels
DEV: backend Python, databases, networking, filesystem...

Comments

@akolson
Copy link
Member

akolson commented Mar 31, 2023 •
edited by rtibbles
Loading

Summary

In order to better handle functionalities associated with ip addresses, there is need to implement a utility library that can be used across the platform. ipaddress has been vendored however, it only supports python 3+.

As such, this task is to remove the vendored ipaddress, which we added to provide support for python 2.7.
@akolson akolson added the DEV: backend Python, databases, networking, filesystem... label Mar 31, 2023
@akolson akolson mentioned this issue Mar 31, 2023
Merged
9 tasks
@akolson akolson changed the title Strip vendored ipaddress standard lib further provide python 2.7+ support for ipaddress & strips unnecessary parts in code Apr 5, 2023
@rtibbles
Copy link
Member

I think we can probably let this lie, and just focus on unvendoring it when we drop Python 2.7 support.

@rtibbles rtibbles changed the title provide python 2.7+ support for ipaddress & strips unnecessary parts in code Remove vendored ipaddress module when we drop Python 2.7 support Apr 15, 2023
@rtibbles rtibbles mentioned this issue Apr 15, 2023
Closed
@rtibbles rtibbles mentioned this issue Dec 15, 2023
Merged
9 tasks
@rtibbles rtibbles self-assigned this Dec 15, 2023
@rtibbles
Copy link
Member

rtibbles commented Jan 2, 2024

Fixed in #11654

@rtibbles rtibbles closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtibbles rtibbles

Labels
DEV: backend Python, databases, networking, filesystem...
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rtibbles @akolson