Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Coach tabs accessibility - "Reports-Activity" tabs on a Reports learner page #10255

Closed
3 tasks
MisRob opened this issue Mar 15, 2023 · 3 comments
Closed
3 tasks
Assignees
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend TAG: a11y Affecting accessibility

Comments

@MisRob
Copy link
Member

MisRob commented Mar 15, 2023

In #10212, we embarked on the journey toward improved accessibility of the coach plugin. Part of it is refactoring tabs logic to use new KDS tabs components that are implemented in an accessible manner. This issue is a continuation of that work.

The goal is to use the KDS tabs components for Reports-Activity tabs on a learner page in the coach reports (Coach → Reports → Learners → select a learner → learner page)

report-activity

Acceptance criteria

  • The current implementation is refactored to use KDS tabs components (KTabs or the combination of KTabsList + KTabsPanel)
  • The new implementation satisfies these and these W3C guidelines (this is already provided by KDS tabs components, however in some cases, a bit of additional Kolibri logic may be needed as well - see comments below)
  • The focus ring shows when navigating with a keyboard and stays on the selected tab after pressing enter

Comments

  • KDS tabs components documentation
  • You can play around with the Lessons-Quizzes-Groups-Learners tabs that are already implemented with KDS components to experience the expected behavior
    example
  • In some cases, due to the routing architecture, some additional Kolibri logic may be needed to ensure seamless focus behavior. If you run into issues with the focus ring disappearing after pressing enter on a tab or similar, useCoachTabs composable may help
@MisRob MisRob added TAG: a11y Affecting accessibility APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Mar 15, 2023
@LianaHarris360 LianaHarris360 self-assigned this Apr 18, 2023
@LianaHarris360 LianaHarris360 removed their assignment Jun 20, 2023
@muditchoudhary
Copy link
Contributor

muditchoudhary commented Oct 16, 2023

Hi @MisRob Can I work on this issue? or is this for only internal team? as it does not have a help-wanted label.

I played around a bit, I think I can work on it. If I can work on it? Could you please assign it to me too?

@MisRob
Copy link
Member Author

MisRob commented Oct 16, 2023

Hi @muditchoudhary, yes, this would be great improvement to Kolibri's accessibility and I believe there's even more places like this.

It may be a bit more complex, but you already have some experience and there are also many references linked in the issue description that you can use as guidance (especially the original PR and useCoachTabs composable, if that's needed).

Feel free to work step by step in a draft PR and if you had any questions, we can figure out next steps there.

@MisRob
Copy link
Member Author

MisRob commented Dec 7, 2023

Closed by #11501

@MisRob MisRob closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend TAG: a11y Affecting accessibility
Projects
None yet
Development

No branches or pull requests

3 participants