Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Coach tabs accessibility - "Report-Learners" tabs on a Reports lesson page #10254

Closed
3 tasks
MisRob opened this issue Mar 15, 2023 · 3 comments · Fixed by #11606
Closed
3 tasks

Improve Coach tabs accessibility - "Report-Learners" tabs on a Reports lesson page #10254

MisRob opened this issue Mar 15, 2023 · 3 comments · Fixed by #11606
Assignees
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend TAG: a11y Affecting accessibility

Comments

@MisRob
Copy link
Member

MisRob commented Mar 15, 2023

In #10212, we embarked on the journey toward improved accessibility of the coach plugin. Part of it is refactoring tabs logic to use new KDS tabs components that are implemented in an accessible manner. This issue is a continuation of that work.

The goal is to use the KDS tabs components for Report-Learners tabs on a lesson page in the coach reports ( Coach → Reports → Lessons → select a lesson → lesson page)

report-learners

Acceptance criteria

  • The current implementation is refactored to use KDS tabs components (KTabs or the combination of KTabsList + KTabsPanel)
  • The new implementation satisfies these and these W3C guidelines (this is already provided by KDS tabs components, however in some cases, a bit of additional Kolibri logic may be needed as well - see comments below)
  • The focus ring shows when navigating with a keyboard and stays on the selected tab after pressing enter

Comments

  • KDS tabs components documentation
  • You can play around with the Lessons-Quizzes-Groups-Learners tabs that are already implemented with KDS components to experience the expected behavior
    example
  • In some cases, due to the routing architecture, some additional Kolibri logic may be needed to ensure seamless focus behavior. If you run into issues with the focus ring disappearing after pressing enter on a tab or similar, useCoachTabs composable may help
@MisRob MisRob added TAG: a11y Affecting accessibility APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Mar 15, 2023
@muditchoudhary
Copy link
Contributor

Hello @MisRob Could you assign it to me? I can work on this. Thanks!

@MisRob
Copy link
Member Author

MisRob commented Nov 28, 2023

Hi @muditchoudhary, yes, thank you! Even though I haven't finished the second round of my review on your first PR from this category, I am already sure that it's implemented very well overall. Here, you can apply the same approach.

These are great improvements to a11y which matters to us.

@muditchoudhary
Copy link
Contributor

Hi @muditchoudhary, yes, thank you! Even though I haven't finished the second round of my review on your first PR from this category, I am already sure that it's implemented very well overall. Here, you can apply the same approach.

These are great improvements to a11y which matters to us.

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend TAG: a11y Affecting accessibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants