From f47d5b7803c6d708380c8996fecbf5d79198f5b1 Mon Sep 17 00:00:00 2001 From: Devon Rueckner Date: Mon, 12 Apr 2021 12:56:56 -0700 Subject: [PATCH 1/2] revert change in a50529ddbdb6ff8cccbc4cfb322135743f878639 --- lib/buttons-and-links/KIconButton.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/buttons-and-links/KIconButton.vue b/lib/buttons-and-links/KIconButton.vue index 59f499409..17f6eab2a 100644 --- a/lib/buttons-and-links/KIconButton.vue +++ b/lib/buttons-and-links/KIconButton.vue @@ -80,14 +80,14 @@ */ ariaLabel: { type: String, - default: null, + default: null, // https://github.com/learningequality/kolibri-design-system/issues/168 }, /** * Tooltip label */ tooltip: { type: String, - required: true, + default: null, // https://github.com/learningequality/kolibri-design-system/issues/168 }, }, computed: { From f8438f19f16fbd8d3bf46beeac1f9cf48ae8b109 Mon Sep 17 00:00:00 2001 From: Devon Rueckner Date: Mon, 12 Apr 2021 13:14:33 -0700 Subject: [PATCH 2/2] linting --- lib/buttons-and-links/KIconButton.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/buttons-and-links/KIconButton.vue b/lib/buttons-and-links/KIconButton.vue index 17f6eab2a..a67501cce 100644 --- a/lib/buttons-and-links/KIconButton.vue +++ b/lib/buttons-and-links/KIconButton.vue @@ -80,14 +80,14 @@ */ ariaLabel: { type: String, - default: null, // https://github.com/learningequality/kolibri-design-system/issues/168 + default: null, // https://github.com/learningequality/kolibri-design-system/issues/168 }, /** * Tooltip label */ tooltip: { type: String, - default: null, // https://github.com/learningequality/kolibri-design-system/issues/168 + default: null, // https://github.com/learningequality/kolibri-design-system/issues/168 }, }, computed: {