Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds add icon add_circle_outline #110

Merged
merged 7 commits into from
Sep 22, 2020
Merged

Adds add icon add_circle_outline #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
30c2715
adds `add` icon `add_circle_outline`
nucleogenesis Sep 22, 2020
db21de4
adds `email` icon mail_outline
nucleogenesis Sep 22, 2020
6b98c03
useful errors on missing icons
nucleogenesis Sep 22, 2020
ac4e5f6
bump to 0.2.2-beta
nucleogenesis Sep 22, 2020
dd4c43f
adds `sidebar` icon vertical_split
nucleogenesis Sep 22, 2020
78ee922
lint
nucleogenesis Sep 22, 2020
10e8c96
morelint
nucleogenesis Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/KIcon/iconDefinitions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,9 @@ const KolibriIcons = {
rtlFlip: true,
},
systemUpdate: { icon: require('./precompiled-icons/material-icons/build/baseline.vue').default },
add: {
icon: require('./precompiled-icons/material-icons/add_circle_outline/baseline.vue').default,
},
remove: { icon: require('./precompiled-icons/mdi/minus-circle-outline.vue').default },
emptyTopic: {
icon: require('./precompiled-icons/material-icons/folder_open/baseline.vue').default,
Expand Down Expand Up @@ -275,6 +278,10 @@ const KolibriIcons = {
collapseAll: { icon: require('./precompiled-icons/mdi/collapse-all.vue').default },
dragHorizontal: { icon: require('./precompiled-icons/le/drag_horizontal.vue').default },
classes: { icon: require('./precompiled-icons/le/class.vue').default },
email: { icon: require('./precompiled-icons/material-icons/mail_outline/baseline.vue').default },
sidebar: {
icon: require('./precompiled-icons/material-icons/vertical_split/baseline.vue').default,
},
};

export { KolibriIcons };
8 changes: 7 additions & 1 deletion lib/KIcon/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,13 @@
type: String,
required: true,
validator(value) {
return Object.keys(KolibriIcons).includes(value);
if (Object.keys(KolibriIcons).includes(value)) {
return true;
} else {
/* eslint-disable-next-line no-console */
console.error(`KIcon: No icon defined for token: ${value}`);
return false;
}
},
},
/**
Expand Down
1 change: 1 addition & 0 deletions lib/buttons-and-links/KIconButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
v-if="tooltip"
open-on="hover"
position="bottom"
style="z-index: 24;"
>
{{ tooltip }}
</UiTooltip>
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "kolibri-design-system",
"version": "0.2.1",
"version": "0.2.2-beta",
"private": false,
"description": "The Kolibri Design System defines common design patterns and code for use in Kolibri applications",
"license": "MIT",
Expand Down
7 changes: 1 addition & 6 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3930,12 +3930,7 @@ caniuse-db@^1.0.30000529, caniuse-db@^1.0.30000634, caniuse-db@^1.0.30000639:
resolved "https://registry.yarnpkg.com/caniuse-db/-/caniuse-db-1.0.30001027.tgz#45dce6c61128324c4534e18ceff6e58e8de76694"
integrity sha512-Ublzr9IN2X91lTvJzehRUlK+hREae1Hi+0TIh7rH5fAcsuPWycwBAszhRGF22gf5xbDXXUdYQ6fSfPSQEqQhkw==

caniuse-lite@^1.0.0, caniuse-lite@^1.0.30000792, caniuse-lite@^1.0.30000805, caniuse-lite@^1.0.30000844, caniuse-lite@^1.0.30000981, caniuse-lite@^1.0.30001016, caniuse-lite@^1.0.30001020, caniuse-lite@^1.0.30001023:
version "1.0.30001122"
resolved "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001122.tgz"
integrity sha512-pxjw28CThdrqfz06nJkpAc5SXM404TXB/h5f4UJX+rrXJKE/1bu/KAILc2AY+O6cQIFtRjV9qOR2vaEp9LDGUA==

caniuse-lite@^1.0.30001043:
caniuse-lite@^1.0.0, caniuse-lite@^1.0.30000792, caniuse-lite@^1.0.30000805, caniuse-lite@^1.0.30000844, caniuse-lite@^1.0.30000981, caniuse-lite@^1.0.30001016, caniuse-lite@^1.0.30001020, caniuse-lite@^1.0.30001023, caniuse-lite@^1.0.30001043:
version "1.0.30001122"
resolved "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001122.tgz"
integrity sha512-pxjw28CThdrqfz06nJkpAc5SXM404TXB/h5f4UJX+rrXJKE/1bu/KAILc2AY+O6cQIFtRjV9qOR2vaEp9LDGUA==
Expand Down