-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docs for z-index & drop-shadow for better clarity #813
Comments
Hey @AlexVelezLl Assign it to me please!!! |
For sure @RONAK-AI647! Thanks for volunteering! |
Hey @AlexVelezLl ,it is mentioned 'Google Material Design elevation image is not relevant to our approach to drop-shadows' |
Hey @RONAK-AI647! Yes, its the same image, but it should be shown in the Z-index section where is more relevant |
@AlexVelezLl ,I am bit confused ,few minutes earlier the pic was this and now it shows this Another thing ,if I just move it to z-index, the dropshadows section would look empty ,as the pic is showcased in an example with a logic code. |
Oh I think you are checking the wrong website 😅. In the issue is described this docs page: https://deploy-preview-723--kolibri-design-system.netlify.app/styling/#elevation which is from our develop branch. There you will find this image which is the one the issue talks about: |
I was doing the same thing ,but due to misconception ,I stepped back....anyways thankyou @AlexVelezLl I have raised the PR. |
Closed by #819 |
🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.
Desired behavior
In discussion re: learningequality/kolibri#12630 we discussed that the (pr 723 Netlify Deploy version) Elevation & Shadow docs is a bit ambiguous and could use a bit of reworking. (Related Notion doc).
This follows up from #723 which added docs for drop-shadows
Acceptance criteria
(Optional) The Value Add
Clearer guidance reduces the potential for confusion while referring to the drop-shadow docs.
The text was updated successfully, but these errors were encountered: