-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KFocusTrap and use it in KModal #746
Comments
hey @MisRob can you assign this to me? |
Hey @lokesh-sagi125, assigning, thank you for volunteering |
hey @MisRob is there any chat server for LE like discord or is it just github? |
Its most likely the line spacing before the <script> tag -- they must be 2 lines. Also the script tag should be at the start of the line and no spaces before it. For example, <template>
...
</template>
<script>
...
</script> |
@lokesh-sagi125 Yes, we have a Slack channel for the community of contributors. You're welcome to send an e-mail to [email protected] to receive an invitation. |
@MisRob Can you please assign this issue to me. |
Hey @iamshobhraj! Thanks for your interest in contributing to this issue! Unfortunately, this is already assigned. But you’re welcome to find a "help wanted" issue with no assignee :). |
Closed by #799 |
🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.
Blocks
Summary
This issue has two related goals
KFocusTrap
componentKFocusTrap
withinKModal
to ensure that users' focus remains contained within the modal interface, preventing accidental interactions with elements outside the modal.Guidance
(1) Create
KFocusTrap
Copy
FocusTrap
from Kolibri to this repository and name it asKFocusTrap
. Follow the guidance for creating a new component.(2) Wrap the content of
KModal
inKFocusTrap
(3) Check that the focus trapping works as expected
on the the playground page.
(4) Add a new documentation page for
KFocusTrap
DocsShow
andDocsShowCode
usage on other documentation pages.The Value Add
Improves accessibility of modals.
Acceptance criteria
KFocusTrap
component including a new documentation pageKFocusTrap
is used withinKModal
and functions as expectedKModal
The text was updated successfully, but these errors were encountered: