You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
KCard needs to support right-to-left languages. This was difficult to preview and test when developing solely in KDS, but as we're transitioning to Kolibri now, we can preview it more easily and ensure that everything works as expected.
One major area is the placement of the thumbnail area. If the thumbnail area appears on the right side in LTR, it should appear on the left side in RTL:
There may be more places to consider, and reviewing the card in all its layout modes in regard to RTL is one of this issue's tasks.
KCard shouldn't be concerned about RTL for any elements that are provided by products via slots. It's the product's responsibility to ensure RTL for such elements.
Example: In the illustration above, KCard ensures that the #aboveTitle slot is rendered on the right side. But it is not (and cannot be) concerned whether icons provided to that slot from a product are mirrored.
Acceptance criteria
All KCard modes are reviewed for RTL
It changes its layout appropriately when used in an RTL language
It is tested in Kolibri in at least one place
The text was updated successfully, but these errors were encountered:
Currently this is what KCard supports by default, no need to reinvent the wheel for now . We will need to do a thorough QA on Kolibri with the new cards that will be built especially with the card grid. @MisRob and I agreed to close this after testing with folder cards and resource cards on Kolibri.
Blocked by
KCard
component #625Summary
KCard
needs to support right-to-left languages. This was difficult to preview and test when developing solely in KDS, but as we're transitioning to Kolibri now, we can preview it more easily and ensure that everything works as expected.One major area is the placement of the thumbnail area. If the thumbnail area appears on the right side in LTR, it should appear on the left side in RTL:
There may be more places to consider, and reviewing the card in all its layout modes in regard to RTL is one of this issue's tasks.
Guidance
KCard
(such as Resource discovery: Implement channel card kolibri#12317, Resource discovery: Implement folder card kolibri#12318, or Resource discovery: Implement resource card kolibri#12319)Out of scope
KCard
shouldn't be concerned about RTL for any elements that are provided by products via slots. It's the product's responsibility to ensure RTL for such elements.KCard
ensures that the#aboveTitle
slot is rendered on the right side. But it is not (and cannot be) concerned whether icons provided to that slot from a product are mirrored.Acceptance criteria
KCard
modes are reviewed for RTLThe text was updated successfully, but these errors were encountered: