Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure KCard supports RTL #665

Closed
3 tasks
MisRob opened this issue Jun 19, 2024 · 1 comment
Closed
3 tasks

Ensure KCard supports RTL #665

MisRob opened this issue Jun 19, 2024 · 1 comment
Assignees
Labels

Comments

@MisRob
Copy link
Member

MisRob commented Jun 19, 2024

Blocked by

Summary

KCard needs to support right-to-left languages. This was difficult to preview and test when developing solely in KDS, but as we're transitioning to Kolibri now, we can preview it more easily and ensure that everything works as expected.

One major area is the placement of the thumbnail area. If the thumbnail area appears on the right side in LTR, it should appear on the left side in RTL:

Screenshot from 2024-06-18 21-12-00

There may be more places to consider, and reviewing the card in all its layout modes in regard to RTL is one of this issue's tasks.

Guidance

Out of scope

  • KCard shouldn't be concerned about RTL for any elements that are provided by products via slots. It's the product's responsibility to ensure RTL for such elements.
    • Example: In the illustration above, KCard ensures that the #aboveTitle slot is rendered on the right side. But it is not (and cannot be) concerned whether icons provided to that slot from a product are mirrored.

Acceptance criteria

  • All KCard modes are reviewed for RTL
  • It changes its layout appropriately when used in an RTL language
  • It is tested in Kolibri in at least one place
@AllanOXDi
Copy link
Member

AllanOXDi commented Sep 5, 2024

Currently this is what KCard supports by default, no need to reinvent the wheel for now . We will need to do a thorough QA on Kolibri with the new cards that will be built especially with the card grid. @MisRob and I agreed to close this after testing with folder cards and resource cards on Kolibri.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants