Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make KResponsiveWindow mixin show deprecation warning #459

Closed
MisRob opened this issue Sep 29, 2023 · 3 comments
Closed

Make KResponsiveWindow mixin show deprecation warning #459

MisRob opened this issue Sep 29, 2023 · 3 comments
Assignees
@ShivangRawat30
Labels
Component: KResponsiveWindowMixin good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome

Comments

@MisRob
Copy link
Member

MisRob commented Sep 29, 2023

We recently implemented useKResponsiveWindow composable that should replace KResponsiveWindow mixin (that will be removed one day).

To make sure that we don't introduce KResponsiveWindow mixin to new places in products consuming Kolibri Design System, it should show a deprecation console warning with a message guiding developers to use useKResponsiveWindow composable instead.
@MisRob MisRob added Component: KResponsiveWindowMixin good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome labels Sep 29, 2023
@ShivangRawat30
Copy link
Contributor

can I work on this issue ?

@MisRob
Copy link
Member Author

MisRob commented Oct 2, 2023

Thanks @ShivangRawat30. assigning you.

@MisRob MisRob mentioned this issue Oct 3, 2023
Merged
7 tasks
@ShivangRawat30 ShivangRawat30 mentioned this issue Oct 6, 2023
Merged
8 tasks
@MisRob
Copy link
Member Author

MisRob commented Oct 13, 2023

Closed by #463

@MisRob MisRob closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShivangRawat30 ShivangRawat30

Labels
Component: KResponsiveWindowMixin good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MisRob @ShivangRawat30