Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDropdownMenu: unexpected behavior in "Facility Settings" view #432

Closed
thanksameeelian opened this issue Apr 17, 2023 · 5 comments
Closed
Assignees
Labels
bug category: library Shared code library Component: KDropdownMenu help wanted Open source contributors welcome P3 - low Priority: Stretch goal product: Kolibri Relevant to a specific issue in Kolibri

Comments

@thanksameeelian
Copy link
Contributor

thanksameeelian commented Apr 17, 2023

Product

Kolibri

Expected behavior

"Option" dropdown will open below the container if there is space available on the page.

Actual behavior

"Option" dropdown opens upward, inside parent container, regardless of space available.
dropdown opens up

Steps to reproduce the issue

Navigate to: Kolibri -> "Facility" tab -> "Facility Settings" subtopic -> "Option" dropdown -> open dropdown

Additional information

📌 GENERAL INFO: over time, issues/bugs have arisen with our usage of vendored KeenUI files - we've struggled to keep up to date with source code without breaking borrowed components we'd already modified, and that has led to some low-priority but cascading dev problems. after internal debate, we've made the decision as a team to consider our forked KeenUI files to be fully our own. as we need to make changes to the components moving forward, we'll make those changes directly without concern for maintaining compatibility with the KeenUI codebase, which continues to change independently (this same description soon to be included in KDS docs). 📌

potential solution referenced by @akolson: we could achieve this behavior by adding support for the constrainToScrollParent prop in KDropdownMenu . This is a Keen Ui's UiPopover prop that by default is set to true to prevent overflows. Under the hood, we are using it to support the KDropdownMenu component. I think it would be a good to have an override to the default behavior. + helpful KeenUI reference:
KeenUI reference

Environment

  • OS: Mac Monterey
  • Browser version: Chrome 112.0.5615.49
@thanksameeelian thanksameeelian added product: Kolibri Relevant to a specific issue in Kolibri Component: KDropdownMenu P3 - low Priority: Stretch goal labels Apr 17, 2023
@thanksameeelian thanksameeelian changed the title KDropdown: unexpected behavior in "Facility Settings" view KDropdownMenu: unexpected behavior in "Facility Settings" view Apr 17, 2023
@MisRob MisRob added category: library Shared code library bug labels Aug 10, 2023
@MisRob MisRob added the help wanted Open source contributors welcome label Feb 23, 2024
@kafukoM
Copy link
Contributor

kafukoM commented Mar 17, 2024

Would like to be assigned to handle this issue.

@MisRob
Copy link
Member

MisRob commented Mar 18, 2024

Hi @kafukoM, thanks for volunteering, I will assign you

@galovdev
Copy link
Contributor

Can I work on this issue? @MisRob

@MisRob
Copy link
Member

MisRob commented Mar 22, 2024

Hi @galovdev, thanks for volunteering. This is already assigned to @kafukoM. Please find a "help wanted" issue with no assignee.

@MisRob
Copy link
Member

MisRob commented May 11, 2024

Closed by #586 and learningequality/kolibri#12015

@MisRob MisRob closed this as completed May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug category: library Shared code library Component: KDropdownMenu help wanted Open source contributors welcome P3 - low Priority: Stretch goal product: Kolibri Relevant to a specific issue in Kolibri
Projects
None yet
Development

No branches or pull requests

4 participants