KDropdownMenu: unexpected behavior in "Facility Settings" view #432
Labels
bug
category: library
Shared code library
Component: KDropdownMenu
help wanted
Open source contributors welcome
P3 - low
Priority: Stretch goal
product: Kolibri
Relevant to a specific issue in Kolibri
Product
Kolibri
Expected behavior
"Option" dropdown will open below the container if there is space available on the page.
Actual behavior
"Option" dropdown opens upward, inside parent container, regardless of space available.
Steps to reproduce the issue
Navigate to: Kolibri -> "Facility" tab -> "Facility Settings" subtopic -> "Option" dropdown -> open dropdown
Additional information
📌 GENERAL INFO: over time, issues/bugs have arisen with our usage of vendored KeenUI files - we've struggled to keep up to date with source code without breaking borrowed components we'd already modified, and that has led to some low-priority but cascading dev problems. after internal debate, we've made the decision as a team to consider our forked KeenUI files to be fully our own. as we need to make changes to the components moving forward, we'll make those changes directly without concern for maintaining compatibility with the KeenUI codebase, which continues to change independently (this same description soon to be included in KDS docs). 📌
potential solution referenced by @akolson:
we could achieve this behavior by adding support for the constrainToScrollParent prop in KDropdownMenu . This is a Keen Ui's UiPopover prop that by default is set to true to prevent overflows. Under the hood, we are using it to support the KDropdownMenu component. I think it would be a good to have an override to the default behavior.
+ helpful KeenUI reference:Environment
The text was updated successfully, but these errors were encountered: