Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit icons used in KIcons to see if any need to be updated so their color can be overridden #395

Closed
marcellamaki opened this issue Dec 8, 2022 · 1 comment · Fixed by #446
Assignees
Labels
category: supporting code Implementation of the system Component: KIcon P1 - important Priority: High impact on UX product: Kolibri Relevant to a specific issue in Kolibri TODO: Needs investigation

Comments

@marcellamaki
Copy link
Member

Product

Kolibri

There have been ongoing occasional instances where KIcons are not exactly the color they are expected. Either the :color prop doesn't work, because the icon is not exported in a format that is overrideable, or the KIcon is being set with a theme token when perhaps it shouldn't.

We may need to adjust KIcon itself to accept default or override colors, adjust how we are using theme tokens, or change the actual icons themselves so that the svg is in a different format, or some combination.

The purpose of this issue is to further investigate and plan, and come up with a proposed solution (which will be a separate issue).

(cc @jtamiace @radinamatic)

@marcellamaki marcellamaki added Component: KIcon category: supporting code Implementation of the system P1 - important Priority: High impact on UX product: Kolibri Relevant to a specific issue in Kolibri labels Dec 8, 2022
@marcellamaki marcellamaki self-assigned this Dec 8, 2022
@laxmikanta415
Copy link

@marcellamaki the default value of the color if no prop is passed is set to null that may be causing the unexpected behaviour.

Can you add screenshot of what the problem scenario exactly is as i am unable to reproduce if a value is set for color prop ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: supporting code Implementation of the system Component: KIcon P1 - important Priority: High impact on UX product: Kolibri Relevant to a specific issue in Kolibri TODO: Needs investigation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants