Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle invalid icon selection #390

Closed
sentry-io bot opened this issue Dec 1, 2022 · 2 comments · Fixed by #391
Closed

Gracefully handle invalid icon selection #390

sentry-io bot opened this issue Dec 1, 2022 · 2 comments · Fixed by #391
Assignees

Comments

@sentry-io
Copy link

sentry-io bot commented Dec 1, 2022

If an unregistered icon name is passed to KIcon, then it will cause TypeErrors from trying to access properties of undefined.

Sentry Issue: STUDIO-FCT

TypeError: Cannot read properties of undefined (reading 'icon')
  at lib_KIconvue_type_script_lang_js_.computed.svgIconComponent (../../../../node_modules/kolibri-design-system/lib/KIcon/index.vue:68:1)
  at Watcher.prototype.get (../../../../node_modules/vue/dist/vue.runtime.esm.js:4495:25)
  at Watcher.prototype.evaluate (../../../../node_modules/vue/dist/vue.runtime.esm.js:4597:21)
  at svgIconComponent (../../../../node_modules/vue/dist/vue.runtime.esm.js:4851:17)
  at KIconvue_type_template_id_36cbad00_scoped_true_render (../../../../node_modules/kolibri-design-system/lib/KIcon/index.vue?5e75:5:17)
...
(45 additional frame(s) were not displayed)
@sentry-io
Copy link
Author

sentry-io bot commented Dec 1, 2022

Sentry issue: STUDIO-FJV

@rtibbles
Copy link
Member

rtibbles commented Dec 7, 2022

Fixed in #391

@rtibbles rtibbles closed this as completed Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant