Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KImg: Add 'appearanceOverrides' #371

Closed
3 tasks
MisRob opened this issue Sep 22, 2022 · 1 comment · Fixed by #509
Closed
3 tasks

KImg: Add 'appearanceOverrides' #371

MisRob opened this issue Sep 22, 2022 · 1 comment · Fixed by #509
Labels
category: library Shared code library

Comments

@MisRob
Copy link
Member

MisRob commented Sep 22, 2022

Summary

KImg accepts the Vue dynamic styles object, for example

{
   width: '100%',
   textDecoration: 'none',
   color: $themeTokens.text
}

via appearanceOverrides prop, which will override the component's styling

Epic

Acceptance criteria

  • Using appearanceOverrides modifies the appearance of the component
  • Its attributes always take precedence over any specified styling (e.g. internal component's styles, styles calculated from props, ...)
  • Documentation is updated with all new features. Contains guidance and examples whenever relevant.

Linked issues

@akolson akolson mentioned this issue Sep 22, 2022
5 tasks
@MisRob MisRob changed the title [TBD] KImg: Add 'appearanceOverrides' KImg: Add 'appearanceOverrides' Sep 23, 2022
@EshaanAgg
Copy link
Contributor

Hi! I want to work on this issue.
Since the Kolibri team is on a break for the holidays, I am taking the liberty to work on the issue without being explicitly assigned. Hope that's okay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: library Shared code library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants