Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outer div shifts slightly when focus is on KTextbox #238

Closed
sairina opened this issue May 29, 2021 · 0 comments
Closed

Outer div shifts slightly when focus is on KTextbox #238

sairina opened this issue May 29, 2021 · 0 comments
Labels
category: library Shared code library P2 - normal Priority: Nice to have type: issue Something isn't working

Comments

@sairina
Copy link
Contributor

sairina commented May 29, 2021

Product

Kolibri

Expected behavior

The size of the outer div containing the KTextbox component should not move.

Actual behavior

All of the contents in outer div containing KTextbox shift slightly down every time a focus appears.

Steps to reproduce the issue

  1. Go to any KTextbox element
  2. Click on it (or use the keyboard to tab into it) and notice the slight shift. It is more noticeable when there is error validation.

Environment

  • OS: Mac
  • Browser version: Chrome

Additional information

@indirectlylit From here:

One thing I'm seeing is that the vertical layout is shifting slightly on focus – though this might be due to the validation and not the new focus outline. Preferably, neither of these would cause a shift in height.

I double-checked with both clicking by mouse or tabbing with the keyboard and it seems to shift with focus, which I think means that it is validation-related. I will open a separate issue for this problem.

2021-05-24 15 02 52

Originally posted by @sairina in #191 (comment)

@sairina sairina changed the title Vertical layout shifts slightly on focus for KTextbox Outer div shifts slightly when focus is on KTextbox May 29, 2021
@nucleogenesis nucleogenesis added category: library Shared code library P2 - normal Priority: Nice to have tag: beginner friendly type: issue Something isn't working labels Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: library Shared code library P2 - normal Priority: Nice to have type: issue Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants