Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KDropdownMenu issues #164

Closed
indirectlylit opened this issue Feb 16, 2021 · 1 comment
Closed

KDropdownMenu issues #164

indirectlylit opened this issue Feb 16, 2021 · 1 comment
Labels
category: library Shared code library Component: KDropdownMenu P1 - important Priority: High impact on UX type: issue Something isn't working type: proposal New feature or request

Comments

@indirectlylit
Copy link
Contributor

indirectlylit commented Feb 16, 2021 •
edited
Loading

The KDropdownMenu component implements full buttons with menus like these:

image

A couple issues:

  • The name implies that it would just implement a menu, but it actually implements buttons that happen to have a menu
  • It doesn't play nicely with KButtonGroup, which doesn't add internal spacing as expected

Recommend deprecating this component entirely, and adding an options property to KButton and removing hasDropdown.
@indirectlylit indirectlylit added category: library Shared code library type: proposal New feature or request type: issue Something isn't working labels Feb 20, 2021
@indirectlylit indirectlylit mentioned this issue Feb 27, 2021
Merged
@nucleogenesis nucleogenesis added the P1 - important Priority: High impact on UX label Mar 12, 2021
@rtibbles rtibbles added the TODO: needs decisions Further discussion and planning necessary label Mar 30, 2021
@marcellamaki marcellamaki mentioned this issue Jul 29, 2022
Merged
14 tasks
@MisRob MisRob added Component: KDropdownMenu and removed TODO: needs decisions Further discussion and planning necessary labels Aug 31, 2022
@MisRob
Copy link
Member

MisRob commented Sep 28, 2023

Closed by #346

@MisRob MisRob closed this as completed Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: library Shared code library Component: KDropdownMenu P1 - important Priority: High impact on UX type: issue Something isn't working type: proposal New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rtibbles @indirectlylit @nucleogenesis @MisRob