Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update breadcrumbs usage guidance #129

Closed
indirectlylit opened this issue Nov 22, 2017 · 0 comments · Fixed by #292
Closed

update breadcrumbs usage guidance #129

indirectlylit opened this issue Nov 22, 2017 · 0 comments · Fixed by #292
Assignees
Labels
category: docs content Design patterns and component usage type: task Something that needs to be done

Comments

@indirectlylit
Copy link
Contributor

In a recent change related to granular import/export (#2610), we added a new prop to the core breadcrumbs component:

+      /**
 +       * When set to 'true', a breadcrumb will be shown for each item in 'items' array.
 +       * Otherwise, the first item will be omitted.
 +       */
 +      showAllCrumbs: {
 +        type: Boolean,
 +        default: false,
 +      },

https://github.com/learningequality/kolibri/pull/2610/files#diff-d37333989ca3443ceed46359f1fab1feR113

We need to update the style guide to give guidance on when this prop is intended to be used.

cc @khangmach @jtamiace @jonboiser @christianmemije

@jonboiser jonboiser assigned jonboiser and unassigned jonboiser Nov 27, 2017
@jonboiser jonboiser transferred this issue from learningequality/kolibri Nov 3, 2020
@indirectlylit indirectlylit added category: docs content Design patterns and component usage type: task Something that needs to be done labels Nov 30, 2021
@MisRob MisRob self-assigned this Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: docs content Design patterns and component usage type: task Something that needs to be done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants