Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: learningequality/kolibri-design-system
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.4.1
Choose a base ref
...
head repository: learningequality/kolibri-design-system
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.5.0
Choose a head ref
  • 10 commits
  • 5 files changed
  • 4 contributors

Commits on Aug 28, 2024

  1. Copy the full SHA
    1c5a0f8 View commit details
  2. Copy the full SHA
    cd1b283 View commit details
  3. Merge pull request #759 from AlexVelezLl/add-invisible-comment

    Backport needed changes to automate changelog updates in release-v4
    rtibbles authored Aug 28, 2024
    Copy the full SHA
    4424aa9 View commit details

Commits on Aug 29, 2024

  1. KCheckbox: Remove local state management, rely on given props

        KCheckbox had local data which are initialized to the given props for
        `indeterminate` and `checked` and then updated in a watcher. This
        resulted in that clicking a checkbox would always toggle it's
        `isCurrentlyChecked` value and setting `isCurrentlyIndeterminate` to
        false.
    
        The changes here instead have KCheckbox simply use the given prop values
        and does nothing to manage any internal state around whether it shows
        `indeterminate` and/or `checked`.
    
        This results in users of KCheckbox needing to be mindful of how they
        manage the values they pass into KCheckbox's props as the component will
        now reflect their values at all time
    nucleogenesis committed Aug 29, 2024
    Copy the full SHA
    325a8ca View commit details

Commits on Sep 3, 2024

  1. Copy the full SHA
    49aaebe View commit details
  2. Merge pull request #744 from nucleogenesis/kcheckbox-unopinionated

    KCheckbox: Remove local state management, rely on given props
    AlexVelezLl authored Sep 3, 2024
    Copy the full SHA
    186b179 View commit details
  3. Copy the full SHA
    8adb365 View commit details
  4. Copy the full SHA
    fe5325b View commit details
  5. Copy the full SHA
    d5dc8f3 View commit details
  6. Merge pull request #767 from AlexVelezLl/release-v4-prep

    Bump KDS version to 4.5.0
    AlexVelezLl authored Sep 3, 2024
    Copy the full SHA
    c7432ff View commit details
Loading