From e45b7c32957297eff8d42cd78b55d92abca1563d Mon Sep 17 00:00:00 2001 From: Marcella Maki Date: Tue, 7 May 2024 13:48:25 -0400 Subject: [PATCH] Replace points leaf active icon, and remove unused pointsLeafInactive icon from icon set --- CHANGELOG.md | 11 +++++++++++ custom-icons/pointsLeafActive.svg | 4 +++- custom-icons/pointsLeafInactive.svg | 1 - docs/rstIconReplacements.txt | 3 +-- lib/KIcon/iconDefinitions.js | 4 ---- lib/KIcon/precompiled-icons/le/pointsLeafActive.vue | 4 ++-- .../precompiled-icons/le/pointsLeafInactive.vue | 12 ------------ 7 files changed, 17 insertions(+), 22 deletions(-) delete mode 100644 custom-icons/pointsLeafInactive.svg delete mode 100644 lib/KIcon/precompiled-icons/le/pointsLeafInactive.vue diff --git a/CHANGELOG.md b/CHANGELOG.md index 7dd4fab3e..afe7fec08 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,17 @@ Changelog is rather internal in nature. See release notes for the public overvie ## Version 4.x.x (`release-v4` branch) +- [#630] + - **Description:** Updates the svg for the pointsLeafActive, and removes the pointsLeafInactive (which is not used anywhere in Kolibri) + - **Products impact:** Kolibri (branding) + - **Addresses:** - + - **Components:** `KIcon` and documentation + - **Breaking:** No + - **Impacts a11y:** No + - **Guidance:** - + +[#630]: https://github.com/learningequality/kolibri-design-system/pull/630 + - [#627] - **Description:** Fix missing anchor tag and heading case in `KTextbox` documentation - **Products impact:** None diff --git a/custom-icons/pointsLeafActive.svg b/custom-icons/pointsLeafActive.svg index 7c5be4fe4..12176d05a 100644 --- a/custom-icons/pointsLeafActive.svg +++ b/custom-icons/pointsLeafActive.svg @@ -1 +1,3 @@ - + + + diff --git a/custom-icons/pointsLeafInactive.svg b/custom-icons/pointsLeafInactive.svg deleted file mode 100644 index 8dde472d2..000000000 --- a/custom-icons/pointsLeafInactive.svg +++ /dev/null @@ -1 +0,0 @@ - diff --git a/docs/rstIconReplacements.txt b/docs/rstIconReplacements.txt index 82095383e..c42c9d275 100644 --- a/docs/rstIconReplacements.txt +++ b/docs/rstIconReplacements.txt @@ -125,8 +125,7 @@ .. |person| replace:: :raw-html:`` .. |pinned| replace:: :raw-html:`` .. |plus| replace:: :raw-html:`` -.. |pointsActive| replace:: :raw-html:`` -.. |pointsInactive| replace:: :raw-html:`` +.. |pointsActive| replace:: :raw-html:`` .. |practiceShaded| replace:: :raw-html:`` .. |practiceSolid| replace:: :raw-html:`` .. |print| replace:: :raw-html:`` diff --git a/lib/KIcon/iconDefinitions.js b/lib/KIcon/iconDefinitions.js index d9022b812..2d6fe6505 100644 --- a/lib/KIcon/iconDefinitions.js +++ b/lib/KIcon/iconDefinitions.js @@ -397,10 +397,6 @@ const KolibriIcons = { icon: require('./precompiled-icons/le/pointsLeafActive.vue').default, defaultColor: themeTokens().text, }, - pointsInactive: { - icon: require('./precompiled-icons/le/pointsLeafInactive.vue').default, - defaultColor: themeTokens().text, - }, classes: { icon: require('./precompiled-icons/le/class.vue').default }, email: { icon: require('./precompiled-icons/material-icons/mail_outline/baseline.vue').default }, sidebar: { diff --git a/lib/KIcon/precompiled-icons/le/pointsLeafActive.vue b/lib/KIcon/precompiled-icons/le/pointsLeafActive.vue index dbb8656b0..83245348b 100644 --- a/lib/KIcon/precompiled-icons/le/pointsLeafActive.vue +++ b/lib/KIcon/precompiled-icons/le/pointsLeafActive.vue @@ -1,12 +1,12 @@ \ No newline at end of file diff --git a/lib/KIcon/precompiled-icons/le/pointsLeafInactive.vue b/lib/KIcon/precompiled-icons/le/pointsLeafInactive.vue deleted file mode 100644 index 396be5d1c..000000000 --- a/lib/KIcon/precompiled-icons/le/pointsLeafInactive.vue +++ /dev/null @@ -1,12 +0,0 @@ - - - - \ No newline at end of file