From 8097b47cf48fa11de25c13e1cd5a3f8e2cdbab3e Mon Sep 17 00:00:00 2001 From: MisRob Date: Sat, 18 Nov 2023 15:09:39 +0100 Subject: [PATCH 1/5] Update contributing guidelines - Suggest contributors ask for a reasonable amount of issues - Add a note on our response times - Add "How to connect section" - Remove "Kolibri Design System" when possible so that guidelines can be copied/pasted more easily accross other repositories - Mark important points in bold - Minor wording tweaks --- CHANGELOG.md | 10 ++++++++++ CONTRIBUTING.md | 30 ++++++++++++++++++++---------- README.md | 27 +++++++++++++++++++-------- 3 files changed, 49 insertions(+), 18 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a12a944e4..4ae983a72 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,16 @@ Changelog is rather internal in nature. See release notes for the public overvie ## Upcoming version +- [#494] + - **Description:** Update contributing guidelines + - **Products impact:** none + - **Addresses:** - + - **Components:** - + - **Breaking:** - + - **Impacts a11y:** - + - **Guidance:** - + +[#494]: [https://github.com/learningequality/kolibri-design-system/pull/494] ## Version 2.0.0 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 19f17f984..a0ad45bc7 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,17 +1,27 @@ +## How can I contribute? -# How can I contribute? - -1. 💻 Follow the [Getting started](./dev_docs/01_getting_started.md) to set up your development server. At the bottom of that page, you will also find links that will take you to guidelines for the most common tasks. -2. 🔍 Search for issues tagged as [help wanted](https://github.com/learningequality/kolibri-design-system/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22+no%3Aassignee+) or [good first issue](https://github.com/learningequality/kolibri-design-system/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22+no%3Aassignee). -3. 🗣️ Ask us for an assignment in the comments of an issue you've chosen. - -Note that in times of increased contributions activity, it may take us a few days to reply. If you don't hear from us within a week, please reach out via [Kolibri Design System GitHub Discussions](https://github.com/learningequality/kolibri-design-system/discussions). +1. 💻 **Follow the [Getting started](./dev_docs/01_getting_started.md) to set up your development server.** At the bottom of the page, you can also find links that will take you to guidelines for the most common tasks. +2. 🔍 **Search for issues tagged as [help wanted](https://github.com/learningequality/kolibri-design-system/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22+no%3Aassignee+) or [good first issue](https://github.com/learningequality/kolibri-design-system/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22+no%3Aassignee).** +4. 🗣️ **Ask us for an assignment in the comments of an issue you've chosen.** Please request assignment of a reasonable amount of issues at a time. Once you finish your current issue or two, you are welcome to ask for more. **❓ Where to ask questions** -- For anything development related, refer to the [developer documentation](./dev_docs/) at first. Some answers may already be there. +- For anything development related, refer to the [Developer documentation](./dev_docs/) at first. Some answers may already be there. - For questions related to a specific issue or assignment requests, use the corresponding issue's comments section. -- Visit [Kolibri Design System GitHub Discussions](https://github.com/learningequality/kolibri-design-system/discussions) to ask about anything related to contributing to Kolibri Design System, troubleshoot development server issues, or connect with other contributors. +- Visit [GitHub Discussions](https://github.com/learningequality/kolibri-design-system/discussions) to ask about anything related to contributing or to troubleshoot development server issues. + +**👥 How to connect** + +- We encourage you to visit [GitHub Discussions](https://github.com/learningequality/kolibri/discussions) to connect with the Learning Equality team as well as with other contributors. +- If you'd like to contribute on a regular basis, we are happy to invite you to our open-source community Slack channel. Get in touch with us at info@learningequality.org to receive an invitation. + +--- + +🕖 Please allow us a few days to reply to your comments. If you don't hear from us within a week, reach out via [GitHub Discussions](https://github.com/learningequality/kolibri/discussions). + +As soon as you open a pull request, it may take us a week or two to review it as we're a small team. We appreciate your contribution and will provide feedback. + +--- -*Thank you for your interest in contributing to Kolibri Design System! The Kolibri project was founded by volunteers dedicated to helping make educational materials more accessible to those in need, and every contribution makes a difference.* +*Thank you for your interest in contributing! Learning Equality was founded by volunteers dedicated to helping make educational materials more accessible to those in need, and every contribution makes a difference.* diff --git a/README.md b/README.md index fda13d6dd..91dfc3b7b 100644 --- a/README.md +++ b/README.md @@ -45,16 +45,27 @@ If you have found a bug, you can create a [Github issue](https://github.com/lear ## How can I contribute? -1. 💻 Follow the [Getting started](./dev_docs/01_getting_started.md) to set up your development server. At the bottom of that page, you will also find links that will take you to guidelines for the most common tasks. -2. 🔍 Search for issues tagged as [help wanted](https://github.com/learningequality/kolibri-design-system/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22+no%3Aassignee+) or [good first issue](https://github.com/learningequality/kolibri-design-system/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22+no%3Aassignee). -3. 🗣️ Ask us for an assignment in the comments of an issue you've chosen. - -Note that in times of increased contributions activity, it may take us a few days to reply. If you don't hear from us within a week, please reach out via [Kolibri Design System GitHub Discussions](https://github.com/learningequality/kolibri-design-system/discussions). +1. 💻 **Follow the [Getting started](./dev_docs/01_getting_started.md) to set up your development server.** At the bottom of the page, you can also find links that will take you to guidelines for the most common tasks. +2. 🔍 **Search for issues tagged as [help wanted](https://github.com/learningequality/kolibri-design-system/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22+no%3Aassignee+) or [good first issue](https://github.com/learningequality/kolibri-design-system/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22+no%3Aassignee).** +4. 🗣️ **Ask us for an assignment in the comments of an issue you've chosen.** Please request assignment of a reasonable amount of issues at a time. Once you finish your current issue or two, you are welcome to ask for more. **❓ Where to ask questions** -- For anything development related, refer to the [developer documentation](./dev_docs/) at first. Some answers may already be there. +- For anything development related, refer to the [Developer documentation](./dev_docs/) at first. Some answers may already be there. - For questions related to a specific issue or assignment requests, use the corresponding issue's comments section. -- Visit [Kolibri Design System GitHub Discussions](https://github.com/learningequality/kolibri-design-system/discussions) to ask about anything related to contributing to Kolibri Design System, troubleshoot development server issues, or connect with other contributors. +- Visit [GitHub Discussions](https://github.com/learningequality/kolibri-design-system/discussions) to ask about anything related to contributing or to troubleshoot development server issues. + +**👥 How to connect** + +- We encourage you to visit [GitHub Discussions](https://github.com/learningequality/kolibri/discussions) to connect with the Learning Equality team as well as with other contributors. +- If you'd like to contribute on a regular basis, we are happy to invite you to our open-source community Slack channel. Get in touch with us at info@learningequality.org to receive an invitation. + +--- + +🕖 Please allow us a few days to reply to your comments. If you don't hear from us within a week, reach out via [GitHub Discussions](https://github.com/learningequality/kolibri/discussions). + +As soon as you open a pull request, it may take us a week or two to review it as we're a small team. We appreciate your contribution and will provide feedback. + +--- -*Thank you for your interest in contributing to Kolibri Design System! The Kolibri project was founded by volunteers dedicated to helping make educational materials more accessible to those in need, and every contribution makes a difference.* +*Thank you for your interest in contributing! Learning Equality was founded by volunteers dedicated to helping make educational materials more accessible to those in need, and every contribution makes a difference.* From 2c7818148bb47dfc24e18afcd207d74eb0fc21ff Mon Sep 17 00:00:00 2001 From: MisRob Date: Mon, 27 Nov 2023 09:45:18 +0100 Subject: [PATCH 2/5] Remove changelog section to align it with the current process of updating the changelog --- CHANGELOG.md | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4ae983a72..6fe442910 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,8 +15,6 @@ Changelog is rather internal in nature. See release notes for the public overvie [#494]: [https://github.com/learningequality/kolibri-design-system/pull/494] -## Version 2.0.0 - - [#478] - **Description:** Changed _dev-only to dev-only - **Products impact:** - @@ -25,10 +23,10 @@ Changelog is rather internal in nature. See release notes for the public overvie - **Breaking:** no - **Impacts a11y:** no - **Guidance:** - - - [#478]: https://github.com/learningequality/kolibri-design-system/pull/478 - - [#482] +[#478]: https://github.com/learningequality/kolibri-design-system/pull/478 + +- [#482] - **Description:** Changed develop branch to main branch in Readme - **Products impact:** - - **Addresses:** https://github.com/learningequality/kolibri-design-system/issues/479 @@ -36,8 +34,8 @@ Changelog is rather internal in nature. See release notes for the public overvie - **Breaking:** no - **Impacts a11y:** no - **Guidance:** - - - [#482]: https://github.com/learningequality/kolibri-design-system/pull/482 + +[#482]: https://github.com/learningequality/kolibri-design-system/pull/482 - [#464] - **Description:** Add KTextTruncator From 7e02dca70f6d7f717aa639b834b6bd665a2e4026 Mon Sep 17 00:00:00 2001 From: MisRob Date: Thu, 30 Nov 2023 13:47:57 +0100 Subject: [PATCH 3/5] Fix link --- CONTRIBUTING.md | 2 +- README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a0ad45bc7..9deda8445 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -13,7 +13,7 @@ **👥 How to connect** -- We encourage you to visit [GitHub Discussions](https://github.com/learningequality/kolibri/discussions) to connect with the Learning Equality team as well as with other contributors. +- We encourage you to visit [GitHub Discussions](https://github.com/learningequality/kolibri-design-system/discussions) to connect with the Learning Equality team as well as with other contributors. - If you'd like to contribute on a regular basis, we are happy to invite you to our open-source community Slack channel. Get in touch with us at info@learningequality.org to receive an invitation. --- diff --git a/README.md b/README.md index 91dfc3b7b..4c960e1ba 100644 --- a/README.md +++ b/README.md @@ -57,7 +57,7 @@ If you have found a bug, you can create a [Github issue](https://github.com/lear **👥 How to connect** -- We encourage you to visit [GitHub Discussions](https://github.com/learningequality/kolibri/discussions) to connect with the Learning Equality team as well as with other contributors. +- We encourage you to visit [GitHub Discussions](https://github.com/learningequality/kolibri-design-system/discussions) to connect with the Learning Equality team as well as with other contributors. - If you'd like to contribute on a regular basis, we are happy to invite you to our open-source community Slack channel. Get in touch with us at info@learningequality.org to receive an invitation. --- From 15949f5b52a78e66409995703e1d1db8aa4c74cd Mon Sep 17 00:00:00 2001 From: MisRob Date: Thu, 30 Nov 2023 15:47:05 +0100 Subject: [PATCH 4/5] A little changelog fix --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1743b8cb8..1bb9589fe 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -32,7 +32,7 @@ Changelog is rather internal in nature. See release notes for the public overvie - **Addresses:** - - **Components:** KDropdownMenu - **Breaking:** No - - **Impacts a11y:** Does this change improve a11y or adds new features that can be used to improve it? Choose from: yes / no + - **Impacts a11y:** yes - **Guidance:** The @tab event can be used for more precise focus management as the popover by default could end up sending focus to the root HTML element by default. Note that the browser event is passed to the handler function, so you may need/want to call `preventDefault()` on that event depending on your use case. [#497]: https://github.com/learningequality/kolibri-design-system/pull/497 From d97e62ae46af79ae2dba46b547d67fba010cdc8e Mon Sep 17 00:00:00 2001 From: MisRob Date: Thu, 30 Nov 2023 19:30:47 +0100 Subject: [PATCH 5/5] Fix links --- CONTRIBUTING.md | 2 +- README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9deda8445..b80e0c3e5 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -18,7 +18,7 @@ --- -🕖 Please allow us a few days to reply to your comments. If you don't hear from us within a week, reach out via [GitHub Discussions](https://github.com/learningequality/kolibri/discussions). +🕖 Please allow us a few days to reply to your comments. If you don't hear from us within a week, reach out via [GitHub Discussions](https://github.com/learningequality/kolibri-design-system/discussions). As soon as you open a pull request, it may take us a week or two to review it as we're a small team. We appreciate your contribution and will provide feedback. diff --git a/README.md b/README.md index 4c960e1ba..0b119ee2e 100644 --- a/README.md +++ b/README.md @@ -62,7 +62,7 @@ If you have found a bug, you can create a [Github issue](https://github.com/lear --- -🕖 Please allow us a few days to reply to your comments. If you don't hear from us within a week, reach out via [GitHub Discussions](https://github.com/learningequality/kolibri/discussions). +🕖 Please allow us a few days to reply to your comments. If you don't hear from us within a week, reach out via [GitHub Discussions](https://github.com/learningequality/kolibri-design-system/discussions). As soon as you open a pull request, it may take us a week or two to review it as we're a small team. We appreciate your contribution and will provide feedback.