Fix all the test failures

[benjaoming]

Circle CI support has been added to 0.14.x so we can start sorting out the failing tests. I'm not quite convinced that we should be shipping the next 0.14 patch release without having fixed all the tests.
#4385 fixes some of them... once it's merged, it'd be great if someone could fix the areas under their domain / expertise. For instance, Someone Else (TM) should fix the compressor stuff.

You will see in the PR that there are a substantial amount of fixes that could cause problems down the road. Because of limited time this week, I can't fix more than what I'm doing in #4385.

[benjaoming]

@rtibbles BDD tests are passing now, but there are a lot of issues due to compress not being run -- either we use COMPRESS_OFFLINE = True during tests or we somehow create the compressed files before testing (my initial attempt didn't work).

Would you mind taking a look at the compress stuff after #4385 is merged?

[aronasorman]

I think we should place the 0.14.x branch on critical bugfix mode -- 0.15 is ~4 weeks away, and splitting our time on getting tests fixed on 0.14 will take away time from getting 0.15 as stable as possible (which already has passing tests).

[benjaoming]

@aronasorman please look at #4385 before making a judgement.

[benjaoming]

@rtibbles nevermind, I found a way to switch on compression in the tests: 03fdc9d

[rtibbles]

The problem with trying to run the server in actual production mode (i.e. creating the compressed files before we do any tests) is that Django < 1.7 uses the staticfiles app to serve static files during tests. So, any files that get compiled into the static files folder (such as Django Compressor and Django JS Reverse files) don't actually get served during testing.

This is really bad from a testing point of view, especially as we move towards more built front end assets, as it means that our testing environment is divergent from our production environment. I would like to recommend upgrading to at least Django 1.7 to deal with this ASAP.

[benjaoming]

@rtibbles this is just a hindsight attempt to get tests working for the next 0.14.1 release.

[rtibbles]

Does the override_settings decorator not work on a whole test suite, btw? I feel like I have tried it before also, and have then just done something completely different to avoid dynamically altering the settings object directly.

[rtibbles]

I am also wary of these test modifications as, presumably, these would eventually get merged back into develop where these tests were working (until a merge from 0.14.x broke them - but they should be fixed again shortly).

[benjaoming]

@rtibbles I think override_settings is supposed to be used on an individual test case, it only affects what happens in the test, but that can still spill over as certain environments may not be entirely isolated.

[aronasorman]

I believe the general consensus was to extensively test 0.14.x manually. With 0.15 so close to release (~2 weeks), no need to pour more resources into 0.14 any more than the bare minimum.

[benjaoming]

Yeah it's fine, I managed to fix tests in a recently discarded PR and run them locally. Didn't find anything suspicious. See #4385