Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots in documentation are often too small to read (with no way to expand) #4030

Closed
jamalex opened this issue Jul 6, 2015 · 3 comments

Comments

@jamalex
Copy link
Member

jamalex commented Jul 6, 2015

Branch: 0.14.x/develop?

It looks like something changed in the way screenshots are captured, from 0.13 to 0.14 -- if you compare the old docs:
https://learningequality.org/docs/usermanual/userman_admin.html#user-management
with the new docs:
http://field.learningequality.org/develop/docs/usermanual/userman_admin.html#user-management
you can see that the resolution of the screen in the screenshot seems to have been increased, making the text two hard to read.

Two suggestions:

  • Sort out the resolution issue, to render at a more readable scale.
  • Allow the images to be clicked on to pop up a larger version (it looks like the images are actually big, but there's no way to expand them without right-click tricks).
@benjaoming
Copy link
Contributor

It seems to be an issue with pyvirtualdisplay :

    # Start a virtual headless display
    display = Display(visible=0, size=(1024, 768))
    display.start()

That should create a 1024x768 display, but the screenshots seem to be from a much larger window, I think the problem is here:

    # Selenium won't scroll to an element, so we have to make the window size is large enough so that everything is visible
    self.browser.set_window_size(1920, 1080)
    self.browser.implicitly_wait(3)

So instead of resizing the window, we could just maximize it and use javascript and jquery to scroll to the position of the element being captured or add an option for scrolling to the screenshot directive.

@benjaoming
Copy link
Contributor

Have a solution for this, building now, uploading in the morning!

@MCGallaspy
Copy link
Contributor

Fixed in #4075.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants