Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Windows installer for 0.17 #424

Closed
4 tasks
benjaoming opened this issue Oct 2, 2016 · 5 comments
Closed
4 tasks

Updating Windows installer for 0.17 #424

benjaoming opened this issue Oct 2, 2016 · 5 comments
Assignees
Labels
Milestone

Comments

@benjaoming
Copy link
Contributor

benjaoming commented Oct 2, 2016

Summary

  • compileymltojson is no longer a command
  • Docs are built into static-libraries/docs with the make docs target, this should be invoked or copied into the bamboo-build.sh script?
  • Test that the kalite.bat executable still works.
  • Use the new auto-discovered content pack (optional)

Version

  • Installer: Windows
  • Version: 0.17b1
@benjaoming benjaoming added the bug label Oct 2, 2016
@benjaoming benjaoming added this to the 0.17.0 milestone Oct 2, 2016
@benjaoming
Copy link
Contributor Author

Btw. try to see if the Windows installer can bundle the .whl build instead of the tarball?

@mrpau-richard
Copy link
Contributor

mrpau-richard commented Oct 3, 2016

@benjaoming I think we can use the .whl build in KA Lite windows, because We already did it in Kolibri windows installer.

@mrpau-eduard
Copy link
Contributor

mrpau-eduard commented Oct 3, 2016

@benjaoming I try to run make dist command so that I can generate .whl file. I encountered an issue:

Build finished. The HTML pages are in _build/html.
cp -Rf docs/_build/html kalite/static-libraries/docs/
# open docs/_build/html/index.html
# Necessary because NPM may have wrong versions in the cache
npm cache clean
npm install --production
npm WARN package.json [email protected] license should be a valid SPDX license expression
node build.js
Watchify: Found 20 bundles, compiling.
Watchify: Assuming that Khan Util files are already deAMDified
Watchify: 20 Bundles written.
KALITE_HOME=.kalite_dist_tmp bin/kalite manage syncdb --noinput
Traceback (most recent call last):
  File "bin/kalite", line 120, in <module>
    from kalite import cli
ImportError: No module named kalite
make: *** [assets] Error 1
(kalite_builds) ECHO-AIR:ka-lite mrpau-eduard$

@mrpau-eduard
Copy link
Contributor

@benjaoming I get it now. I forgot to issue pip install -e . to install kalite in my virtualenv.
Its building now a .whl file.

@mrpau-richard
Copy link
Contributor

fixed in #427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants