Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical Debt #4

Closed
6 of 8 tasks
justheuristic opened this issue Mar 1, 2020 · 1 comment
Closed
6 of 8 tasks

Technical Debt #4

justheuristic opened this issue Mar 1, 2020 · 1 comment
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@justheuristic
Copy link
Member

justheuristic commented Mar 1, 2020

tesseract.client

  • MoE does not support failures during backward
  • RemoteExpert doesn't check if inputs are valid (should check via info)

tesseract.runtime

  • non-deterministic layers use different random during forward and backward passes
  • layers with batchnorm update stats twice. Update during backward only? upd: we now assume that forward is a pure deterministic function; moved discussion to a separate thread
  • form_batch: when batch is nearly full and the next task has multiple examples, pool adds this task to a batch even if batch size exceeds max_batch_size
  • we probably can shutdown TesseractRuntime without using a dedicated mp.Pipe, see also: eventfd

tesseract.utils

  • SharedFuture: cancel, set_running_or_notify_cancel

tesseract.tests

  • sometimes interrupting tests/benchmark_throughput.py leaves process hanging (only responds to sigterm/sigkill), find & eliminate the cause
@justheuristic justheuristic self-assigned this Mar 1, 2020
@justheuristic justheuristic added bug Something isn't working help wanted Extra attention is needed labels Mar 2, 2020
@justheuristic
Copy link
Member Author

Most issues are solved. Remaining issues merged into #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant