Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withMainContext #132

Open
hrmacbeth opened this issue Oct 29, 2024 · 1 comment
Open

withMainContext #132

hrmacbeth opened this issue Oct 29, 2024 · 1 comment
Labels
doc-request Request for missing documenation

Comments

@hrmacbeth
Copy link

What question should the reference manual answer?

One of the most common tactic bugs (seen at least a dozen times in examples on Zulip or in Mathlib PRs) is a missing withMainContext. What is a context? How is the context determined by default, and how does this change if a tactic is wrapped in withMainContext?

Maybe you could include an example of a small tactic with this error, showing the classic behaviour which signals this bug (tactic mysteriously ignores variables/hypotheses/goals which were not present at the start of the problem), and then a fixed version of the tactic.

@hrmacbeth hrmacbeth added the doc-request Request for missing documenation label Oct 29, 2024
@david-christiansen
Copy link
Collaborator

Thanks, this is useful feedback! I don't plan to address the deep guts of tactic implementation until sometime next year, but this is a very good thing to keep in mind for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-request Request for missing documenation
Projects
None yet
Development

No branches or pull requests

2 participants