You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The use of colGe to implement indentation-sensitive syntax can lead to extremely surprising parses:
example : false := by
conv =>
lhs
dsimp
simp
Namely if dsimp is a conv-tactic then this parses as three conv-tactics (like the indentation suggests). But if dsimp is not a conv-tactic, then this parses as (conv => lhs); dsimp; simp.
We should try out whether a colEq combinator (that enforces uniform indentation) causes any unexpected issues.
Another option (that fixes the particular issue here) would be to implement a fallback elab ident : conv => throwError "unknown conv tactic" like we have for tactic.
The text was updated successfully, but these errors were encountered:
The use of
colGe
to implement indentation-sensitive syntax can lead to extremely surprising parses:Namely if
dsimp
is a conv-tactic then this parses as three conv-tactics (like the indentation suggests). But ifdsimp
is not a conv-tactic, then this parses as(conv => lhs); dsimp; simp
.We should try out whether a
colEq
combinator (that enforces uniform indentation) causes any unexpected issues.Another option (that fixes the particular issue here) would be to implement a fallback
elab ident : conv => throwError "unknown conv tactic"
like we have fortactic
.The text was updated successfully, but these errors were encountered: