From c5ca57c101f2ad3e472f02585bb28a4ca1e95364 Mon Sep 17 00:00:00 2001 From: Alex J Best Date: Thu, 25 Jan 2024 12:45:33 +0000 Subject: [PATCH] feat: problem matchers for tests (#9552) Makes it a bit easier to see which test failed and where --- .github/workflows/bors.yml | 15 +++++++++------ .github/workflows/build.yml | 15 +++++++++------ .github/workflows/build.yml.in | 15 +++++++++------ .github/workflows/build_fork.yml | 15 +++++++++------ 4 files changed, 36 insertions(+), 24 deletions(-) diff --git a/.github/workflows/bors.yml b/.github/workflows/bors.yml index f03a37eac6a0f..23e4ae57c7142 100644 --- a/.github/workflows/bors.yml +++ b/.github/workflows/bors.yml @@ -262,12 +262,15 @@ jobs: lake exe shake - name: test mathlib - id: test - run: | - # Tests use parts of ProofWidgets not imported by Mathlib. - # Ensure everything has been built. - lake build ProofWidgets - make -j 8 test + uses: liskin/gh-problem-matcher-wrap@v2 + with: + linters: gcc + run: | + bash -o pipefail -c " + # Tests use parts of ProofWidgets not imported by Mathlib. + # Ensure everything has been built. + lake build ProofWidgets + make -j 8 test" - name: lint mathlib id: lint diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 1d385611beb0c..6a1ec9da2cac4 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -269,12 +269,15 @@ jobs: lake exe shake - name: test mathlib - id: test - run: | - # Tests use parts of ProofWidgets not imported by Mathlib. - # Ensure everything has been built. - lake build ProofWidgets - make -j 8 test + uses: liskin/gh-problem-matcher-wrap@v2 + with: + linters: gcc + run: | + bash -o pipefail -c " + # Tests use parts of ProofWidgets not imported by Mathlib. + # Ensure everything has been built. + lake build ProofWidgets + make -j 8 test" - name: lint mathlib id: lint diff --git a/.github/workflows/build.yml.in b/.github/workflows/build.yml.in index 42e6c21abe02e..baff780463b21 100644 --- a/.github/workflows/build.yml.in +++ b/.github/workflows/build.yml.in @@ -248,12 +248,15 @@ jobs: lake exe shake - name: test mathlib - id: test - run: | - # Tests use parts of ProofWidgets not imported by Mathlib. - # Ensure everything has been built. - lake build ProofWidgets - make -j 8 test + uses: liskin/gh-problem-matcher-wrap@v2 + with: + linters: gcc + run: | + bash -o pipefail -c " + # Tests use parts of ProofWidgets not imported by Mathlib. + # Ensure everything has been built. + lake build ProofWidgets + make -j 8 test" - name: lint mathlib id: lint diff --git a/.github/workflows/build_fork.yml b/.github/workflows/build_fork.yml index 2627e049125da..8023f82230090 100644 --- a/.github/workflows/build_fork.yml +++ b/.github/workflows/build_fork.yml @@ -266,12 +266,15 @@ jobs: lake exe shake - name: test mathlib - id: test - run: | - # Tests use parts of ProofWidgets not imported by Mathlib. - # Ensure everything has been built. - lake build ProofWidgets - make -j 8 test + uses: liskin/gh-problem-matcher-wrap@v2 + with: + linters: gcc + run: | + bash -o pipefail -c " + # Tests use parts of ProofWidgets not imported by Mathlib. + # Ensure everything has been built. + lake build ProofWidgets + make -j 8 test" - name: lint mathlib id: lint