Better variable inheritance #584
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exhaustively search parents before reverting to scope at time of mixin.
|
This seems fine but I'm hesitant to merge without a test case to confirm it, and also to avoid regressing it in the future. |
# Conflicts: # lessc.inc.php
|
@Krinkle Unfortunately, I don't remember the original LESS that led me to create this modification. It was something in the Bootstrap 2 library... I tried rerunning the code on a few old versions, but was not able to easily identify the issue. Sorry for not adding the test case originally. Probably best to close this until someone posts an issue that can be used to confirm that this is indeed the desired behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was seeing a problem compiling Bootstrap 2.3.2 where the fluid widths were not correctly preserved in the responsive design. This was due to an issue where the mixin scope took precedence over the normal variable inheritance chain. This commit ensures that the standard inheritance chain is fully traversed before considering mixin scope.
There is likely a more graceful way to do this, but I did at least want to offer this solution in case others are running into the same issue.