Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: PR 4871 (iface) #14

Closed
ldez opened this issue Jul 18, 2024 · 3 comments
Closed

benchmark: PR 4871 (iface) #14

ldez opened this issue Jul 18, 2024 · 3 comments

Comments

@ldez
Copy link
Owner

ldez commented Jul 18, 2024

{
"pr": 4871,
"linter": "iface"
}

This comment was marked as outdated.

This comment was marked as outdated.

Copy link

The benchmark (Benchmark PR (new linter)) is done!

beego/beego

client/orm/types.go:127:6: identical: interface txEnder contains identical methods or type constraints from another interface, causing redundancy (iface)
type txEnder interface {
     ^
client/orm/types.go:247:6: identical: interface ormer contains identical methods or type constraints from another interface, causing redundancy (iface)
type ormer interface {
     ^
client/orm/types.go:254:6: identical: interface QueryExecutor contains identical methods or type constraints from another interface, causing redundancy (iface)
type QueryExecutor interface {
     ^
client/orm/types.go:116:6: identical: interface TxCommitter contains identical methods or type constraints from another interface, causing redundancy (iface)
type TxCommitter interface {
     ^
Command Mean [ms] Min [ms] Max [ms] Relative
iface 844.3 ± 11.2 831.7 865.4 1.65 ± 0.02
goconst 510.9 ± 3.3 506.7 516.7 1.00
durationcheck 842.6 ± 6.3 831.4 848.7 1.65 ± 0.02

cilium/cilium

Command Mean [s] Min [s] Max [s] Relative
iface 5.906 ± 0.068 5.819 6.042 1.96 ± 0.03
goconst 3.006 ± 0.018 2.978 3.037 1.00
durationcheck 5.914 ± 0.080 5.792 6.054 1.97 ± 0.03

spf13/cobra

Command Mean [ms] Min [ms] Max [ms] Relative
iface 343.9 ± 4.5 335.8 353.5 1.38 ± 0.03
goconst 249.3 ± 5.1 240.9 256.8 1.00
durationcheck 350.9 ± 9.0 343.1 371.1 1.41 ± 0.05

hashicorp/consul

agent/setup.go:71:6: identical: interface NetRPC contains identical methods or type constraints from another interface, causing redundancy (iface)
type NetRPC interface {
     ^
agent/user_event_test.go:237:6: identical: interface RPC contains identical methods or type constraints from another interface, causing redundancy (iface)
type RPC interface {
     ^
agent/grpc-external/services/peerstream/subscription_manager.go:41:6: identical: interface SubscriptionBackend contains identical methods or type constraints from another interface, causing redundancy (iface)
type SubscriptionBackend interface {
     ^
agent/grpc-external/services/peerstream/subscription_view.go:21:6: identical: interface Subscriber contains identical methods or type constraints from another interface, causing redundancy (iface)
type Subscriber interface {
     ^
agent/proxycfg/data_sources.go:197:6: identical: interface Intentions contains identical methods or type constraints from another interface, causing redundancy (iface)
type Intentions interface {
     ^
agent/proxycfg/data_sources.go:203:6: identical: interface IntentionUpstreams contains identical methods or type constraints from another interface, causing redundancy (iface)
type IntentionUpstreams interface {
     ^
agent/proxycfg/data_sources.go:185:6: identical: interface Health contains identical methods or type constraints from another interface, causing redundancy (iface)
type Health interface {
     ^
agent/proxycfg/data_sources.go:244:6: identical: interface ServiceList contains identical methods or type constraints from another interface, causing redundancy (iface)
type ServiceList interface {
     ^
agent/proxycfg/data_sources.go:151:6: identical: interface ConfigEntry contains identical methods or type constraints from another interface, causing redundancy (iface)
type ConfigEntry interface {
     ^
agent/proxycfg/data_sources.go:169:6: identical: interface FederationStateListMeshGateways contains identical methods or type constraints from another interface, causing redundancy (iface)
type FederationStateListMeshGateways interface {
     ^
agent/proxycfg/data_sources.go:180:6: identical: interface ServiceGateways contains identical methods or type constraints from another interface, causing redundancy (iface)
type ServiceGateways interface {
     ^
agent/proxycfg/data_sources.go:262:6: identical: interface ExportedPeeredServices contains identical methods or type constraints from another interface, causing redundancy (iface)
type ExportedPeeredServices interface {
     ^
agent/proxycfg/data_sources.go:139:6: identical: interface CARoots contains identical methods or type constraints from another interface, causing redundancy (iface)
type CARoots interface {
     ^
agent/proxycfg/data_sources.go:157:6: identical: interface ConfigEntryList contains identical methods or type constraints from another interface, causing redundancy (iface)
type ConfigEntryList interface {
     ^
agent/proxycfg/data_sources.go:175:6: identical: interface GatewayServices contains identical methods or type constraints from another interface, causing redundancy (iface)
type GatewayServices interface {
     ^
Command Mean [s] Min [s] Max [s] Relative
iface 4.928 ± 0.052 4.856 5.015 1.85 ± 0.03
goconst 2.666 ± 0.029 2.631 2.715 1.00
durationcheck 4.941 ± 0.052 4.876 5.035 1.85 ± 0.03

go-delve/delve

Command Mean [ms] Min [ms] Max [ms] Relative
iface 921.6 ± 17.9 889.9 950.1 1.60 ± 0.07
goconst 575.4 ± 21.8 547.0 625.4 1.00
durationcheck 934.8 ± 13.7 917.0 955.2 1.62 ± 0.07

etcd-io/etcd

Command Mean [ms] Min [ms] Max [ms] Relative
iface 595.0 ± 39.8 567.7 674.5 1.87 ± 0.13
goconst 317.4 ± 3.7 311.8 322.2 1.00
durationcheck 574.3 ± 22.6 560.9 636.5 1.81 ± 0.07

go-gitea/gitea

modules/log/event_writer.go:14:6: identical: interface EventWriter contains identical methods or type constraints from another interface, causing redundancy (iface)
type EventWriter interface {
     ^
modules/log/event_writer_base.go:17:6: identical: interface EventWriterBase contains identical methods or type constraints from another interface, causing redundancy (iface)
type EventWriterBase interface {
     ^
Command Mean [s] Min [s] Max [s] Relative
iface 3.490 ± 0.061 3.424 3.632 1.91 ± 0.04
goconst 1.826 ± 0.022 1.789 1.875 1.00
durationcheck 3.478 ± 0.033 3.428 3.533 1.90 ± 0.03

google/go-github

Command Mean [s] Min [s] Max [s] Relative
iface 1.643 ± 0.025 1.607 1.680 2.12 ± 0.04
goconst 0.775 ± 0.009 0.758 0.794 1.00
durationcheck 1.624 ± 0.013 1.596 1.641 2.09 ± 0.03

golangci/golangci-lint

Command Mean [ms] Min [ms] Max [ms] Relative
iface 995.1 ± 12.1 974.5 1015.0 1.75 ± 0.06
goconst 569.7 ± 17.0 553.3 594.6 1.00
durationcheck 1024.8 ± 52.2 980.0 1155.2 1.80 ± 0.11

goreleaser/goreleaser

Command Mean [s] Min [s] Max [s] Relative
iface 1.582 ± 0.103 1.518 1.869 2.07 ± 0.14
goconst 0.765 ± 0.010 0.752 0.779 1.00
durationcheck 1.547 ± 0.009 1.529 1.558 2.02 ± 0.03

grpc/grpc-go

Command Mean [s] Min [s] Max [s] Relative
iface 1.566 ± 0.099 1.500 1.789 1.76 ± 0.11
goconst 0.891 ± 0.006 0.881 0.901 1.00
durationcheck 1.518 ± 0.008 1.499 1.527 1.70 ± 0.01

gohugoio/hugo

resources/resource/resourcetypes.go:227:6: identical: interface TranslationKeyProvider contains identical methods or type constraints from another interface, causing redundancy (iface)
type TranslationKeyProvider interface {
     ^
resources/resource/resources.go:159:6: identical: interface translatedResource contains identical methods or type constraints from another interface, causing redundancy (iface)
type translatedResource interface {
     ^
codegen/methods2_test.go:16:6: identical: interface IEmbed contains identical methods or type constraints from another interface, causing redundancy (iface)
type IEmbed interface {
     ^
codegen/methods_test.go:94:6: identical: interface IEOnly contains identical methods or type constraints from another interface, causing redundancy (iface)
type IEOnly interface {
     ^
Command Mean [s] Min [s] Max [s] Relative
iface 2.551 ± 0.071 2.496 2.736 2.61 ± 0.09
goconst 0.976 ± 0.020 0.953 1.011 1.00
durationcheck 2.526 ± 0.015 2.502 2.550 2.59 ± 0.06

kubernetes/kubernetes

pkg/controller/volume/persistentvolume/metrics/metrics.go:57:6: identical: interface PVLister contains identical methods or type constraints from another interface, causing redundancy (iface)
type PVLister interface {
     ^
pkg/controller/volume/persistentvolume/metrics/metrics.go:62:6: identical: interface PVCLister contains identical methods or type constraints from another interface, causing redundancy (iface)
type PVCLister interface {
     ^
pkg/volume/volume.go:202:6: identical: interface BlockVolumeUnmapper contains identical methods or type constraints from another interface, causing redundancy (iface)
type BlockVolumeUnmapper interface {
     ^
pkg/volume/volume.go:42:6: identical: interface BlockVolume contains identical methods or type constraints from another interface, causing redundancy (iface)
type BlockVolume interface {
     ^
pkg/volume/volume.go:175:6: identical: interface BlockVolumeMapper contains identical methods or type constraints from another interface, causing redundancy (iface)
type BlockVolumeMapper interface {
     ^
Command Mean [s] Min [s] Max [s] Relative
iface 9.506 ± 0.119 9.380 9.749 1.70 ± 0.03
goconst 5.589 ± 0.043 5.524 5.664 1.00
durationcheck 9.358 ± 0.057 9.263 9.466 1.67 ± 0.02

go-acme/lego

Command Mean [s] Min [s] Max [s] Relative
iface 1.935 ± 0.015 1.911 1.962 2.16 ± 0.03
goconst 0.897 ± 0.011 0.885 0.921 1.00
durationcheck 1.918 ± 0.024 1.872 1.955 2.14 ± 0.04

pact-foundation/pact-go

Command Mean [ms] Min [ms] Max [ms] Relative
iface 465.0 ± 6.9 454.5 480.6 1.56 ± 0.08
goconst 297.6 ± 14.3 287.1 337.3 1.00
durationcheck 472.0 ± 13.3 454.8 492.3 1.59 ± 0.09

rclone/rclone

Command Mean [s] Min [s] Max [s] Relative
iface 2.299 ± 0.082 2.215 2.520 1.74 ± 0.06
goconst 1.321 ± 0.013 1.301 1.341 1.00
durationcheck 2.301 ± 0.023 2.269 2.341 1.74 ± 0.02

hashicorp/terraform

Command Mean [s] Min [s] Max [s] Relative
iface 3.114 ± 0.096 3.044 3.375 1.93 ± 0.07
goconst 1.610 ± 0.022 1.572 1.647 1.00
durationcheck 3.126 ± 0.041 3.046 3.190 1.94 ± 0.04

traefik/traefik

pkg/api/sort.go:20:6: identical: interface orderedWithName contains identical methods or type constraints from another interface, causing redundancy (iface)
type orderedWithName interface {
     ^
pkg/api/sort.go:344:6: identical: interface orderedByName contains identical methods or type constraints from another interface, causing redundancy (iface)
type orderedByName interface {
     ^
Command Mean [s] Min [s] Max [s] Relative
iface 3.042 ± 0.095 2.981 3.300 2.66 ± 0.09
goconst 1.143 ± 0.015 1.124 1.166 1.00
durationcheck 2.979 ± 0.046 2.914 3.066 2.61 ± 0.05

You can find the workflow here:
https://github.com/ldez/golangci-lint-bench/actions/runs/11411914408

@ldez ldez closed this as completed Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant