perf: simplify the skip functions

lddubeau · Aug 14, 2018 · c7b8c3b · c7b8c3b
1 parent ac03a1c
commit c7b8c3b
Showing 1 changed file with 8 additions and 22 deletions.
diff --git a/lib/saxes.js b/lib/saxes.js
@@ -572,21 +572,14 @@ class SaxesParser {
    */
   skipWhile(chunkState, test) {
     const { limit } = chunkState;
-    let c;
-    // eslint-disable-next-line no-constant-condition
-    while (true) {
-      if (chunkState.i >= limit) {
-        c = undefined;
-        break;
-      }
-
-      c = this.getCode(chunkState);
+    while (chunkState.i < limit) {
+      const c = this.getCode(chunkState);
       if (!test(c)) {
-        break;
+        return c;
       }
     }
 
-    return c;
+    return undefined;
   }
 
   /**
@@ -601,21 +594,14 @@ class SaxesParser {
    */
   skipWhitespace(chunkState) {
     const { limit } = chunkState;
-    let c;
-    // eslint-disable-next-line no-constant-condition
-    while (true) {
-      if (chunkState.i >= limit) {
-        c = undefined;
-        break;
-      }
-
-      c = this.getCode(chunkState);
+    while (chunkState.i < limit) {
+      const c = this.getCode(chunkState);
       if (!isS(c)) {
-        break;
+        return c;
       }
     }
 
-    return c;
+    return undefined;
   }