perf: don't check twice if this.textNode is set

The current flow would check the variable twice. Just check it before calling `closeText`, everywhere.
lddubeau · Sep 3, 2018 · 00536cc · 00536cc
1 parent e981a25
commit 00536cc
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/saxes.js b/lib/saxes.js
@@ -1569,7 +1569,9 @@ class SaxesParser {
         (this.state !== S_TEXT)) {
       this.fail("unexpected end.");
     }
-    this.closeText();
+    if (this.textNode) {
+      this.closeText();
+    }
     this.closed = true;
     this.onend();
     this._init(this.opt);
@@ -1582,9 +1584,7 @@ class SaxesParser {
    * @private
    */
   closeText() {
-    if (this.textNode) {
-      this.ontext(this.textNode);
-    }
+    this.ontext(this.textNode);
     this.textNode = "";
     this.textNodeCheckedBefore = 0;
   }