Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use library specific exceptions #128

Closed
lcobucci opened this issue Oct 21, 2016 · 1 comment · Fixed by #531
Closed

Use library specific exceptions #128

lcobucci opened this issue Oct 21, 2016 · 1 comment · Fixed by #531
Assignees
@lcobucci
Labels
Improvement
Milestone
4.0.0-beta1

Comments

@lcobucci
Copy link
Owner

As pointed by @renatomefi we're relying on SPL exceptions and would be really good to have an exception tree for this library in order to simplify things while catching exceptions.
@lcobucci lcobucci added this to the 4.0.0 milestone Oct 21, 2016
@lcobucci lcobucci mentioned this issue Oct 24, 2016
Merged
@lcobucci
Copy link
Owner Author

lcobucci commented Jan 7, 2017 •
edited
Loading

Also adding named constructors where they're applicable.

@lcobucci lcobucci removed this from the 4.0.0-alpha1 milestone Feb 27, 2019
@lcobucci lcobucci added this to the 4.0.0-alpha4 milestone Oct 13, 2019
@lcobucci lcobucci mentioned this issue Feb 26, 2020
Closed
@lcobucci lcobucci self-assigned this May 22, 2020
@t0mmy742 t0mmy742 mentioned this issue Oct 12, 2020
Closed
@lcobucci lcobucci removed the BC-break label Nov 9, 2020
@lcobucci lcobucci mentioned this issue Nov 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lcobucci lcobucci

Labels
Improvement
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging a pull request may close this issue.

Use lib exceptions lcobucci/jwt
Use library specific exceptions
1 participant
@lcobucci