Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to send a transaction using all available LBC #1628

Open
tzarebczan opened this issue Nov 9, 2018 · 0 comments · May be fixed by #3605
Open

Add an option to send a transaction using all available LBC #1628

tzarebczan opened this issue Nov 9, 2018 · 0 comments · May be fixed by #3605
Labels

Comments

@tzarebczan
Copy link
Contributor

tzarebczan commented Nov 9, 2018

The Issue

As a daemon or app user, I want to be able to move all my funds from one address to another. Currently, you'd need to send some amount that's smaller than the wallet balance to account for fees. There should be an option that allows all funds to be sent along with the appropriate fee, i.e. a send max scenario.

Steps

  • make it so you can use all as a value to --amount. this signals you want to use your whole available balance
  • create the transaction internally using the full amount, then estimate the fee, then update the transaction to subtract the fee from the full amount

APIs that should support this: support_create, wallet_send, any other api that has a --amount flag

Use case: i want to support my channel with all my available lbc and i don't want to do the math to figure out how much the fee should be.

Take a look txo_fund --everything. There may be reusable code there. (https://github.com/lbryio/lbry-sdk/blob/master/lbry/wallet/account.py#L488)

@tzarebczan tzarebczan added area: wallet type: new feature New functionality that does not exist yet labels Nov 9, 2018
@alyssaoc alyssaoc added the priority: low Work should be done but can stay in the backlog for now label Mar 20, 2019
@eukreign eukreign self-assigned this Jan 25, 2021
@lyoshenka lyoshenka added good first issue and removed priority: low Work should be done but can stay in the backlog for now labels Apr 23, 2021
@lyoshenka lyoshenka changed the title add "send max / all funds" option to wallet_send Add an option to send a transaction using all available LBC Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants