Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List own comments #7171

Merged
merged 7 commits into from
Oct 1, 2021
Merged

List own comments #7171

merged 7 commits into from
Oct 1, 2021

Commits on Oct 1, 2021

  1. Add option to pass in url-search params. 

    Impetus: allow linked comment ID and setting the discussion tab when clicking on the `ClaimPreview`.
    @infinite-persistence
    infinite-persistence committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    876ba50 View commit details
    Browse the repository at this point in the history

  2. comment.list: fix typos and renamed variables 

    - Switch from 'author' to 'creator' to disambiguate between comment author and content author. For comment author, we'll use 'commenter' from now on.
- Corrected 'commenterClaimId' to 'creatorClaimId' (just a typo, no functional change).
    @infinite-persistence
    infinite-persistence committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    99b742a View commit details
    Browse the repository at this point in the history

  3. doCommentReset: change param from uri to claimId 

    This reduces one lookup as clients will always have the claimID ready, but might not have the full URI.

It was using URI previously just to match the other APIs.
    @infinite-persistence
    infinite-persistence committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    5e26926 View commit details
    Browse the repository at this point in the history

  4. Add doCommentListOwn -- command to fetch own comments 

    Since the redux slice is set up based on content or channel ID (for Channel Discussion page), re-use the channel ID for the case of "own comments". We always clear each ID when fetching page-0, so no worries of conflict when actually browsing the Channel Discussion page.
    @infinite-persistence
    infinite-persistence committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    e068df8 View commit details
    Browse the repository at this point in the history

  5. Comment: add option to hide the actions section

    @infinite-persistence
    infinite-persistence committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    69dbdce View commit details
    Browse the repository at this point in the history

  6. Implement own-comments page

    @infinite-persistence
    infinite-persistence committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    53ae7d0 View commit details
    Browse the repository at this point in the history

  7. Use new param to remove sort-pins-first. 

    comment.List currently always pushes pins to the top to support pagination. This new param removes this behavior.
    @infinite-persistence
    infinite-persistence committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    48247cb View commit details
    Browse the repository at this point in the history