Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create fallback/fix for github api lookup #1505

Closed
tzarebczan opened this issue May 23, 2018 · 0 comments
Closed

Create fallback/fix for github api lookup #1505

tzarebczan opened this issue May 23, 2018 · 0 comments
Labels
area: internal type: improvement Existing (or partially existing) functionality needs to be changed

Comments

@tzarebczan
Copy link
Contributor

tzarebczan commented May 23, 2018 •
edited
Loading

After renaming lbry-app >lbry-desktop, the github api does not redirect properly and this line fails:https://github.com/lbryio/lbry-desktop/blob/master/src/main/index.js#L172

This causes the app to crash when going to the help page that looks up version info. On Linux, it crashes on startup.

Create a fallback to the lbry-desktop URL if lbry-app fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: internal type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tzarebczan @lbry-bot