Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow dark mode with automatic night mode enabled #1005

Closed
tzarebczan opened this issue Feb 8, 2018 · 3 comments · Fixed by #1440
Closed

Don't allow dark mode with automatic night mode enabled #1005

tzarebczan opened this issue Feb 8, 2018 · 3 comments · Fixed by #1440
Assignees
@btzr-io @neb-b
Labels
priority: blocker Issue is blocking release, do ASAP

Comments

@tzarebczan
Copy link
Contributor

The Issue

If you enable automatic night mode, the theme selection should not allow the dark theme to be chosen as it overrides the setting. Not sure about disabling the theme selection completely - right now it makes sense because there is only 1 option, but in the future when we have more, a user may want theme X and have night mode enabled.

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots
@kauffj
Copy link
Member

kauffj commented Feb 8, 2018

Probably better to disable the night mode setting once the dark theme has been selected than to disable the theme if night mode is selected.

@neb-b
Copy link

neb-b commented Feb 8, 2018

Fixed in #1006

@neb-b neb-b closed this as completed Feb 8, 2018
@neb-b neb-b reopened this Feb 8, 2018
@neb-b neb-b self-assigned this Feb 12, 2018
@neb-b neb-b closed this as completed Feb 26, 2018
@tzarebczan
Copy link
Contributor Author

Going to re-open this because you can select automatic dark mode while dark is selected, which forces the app to stay in dark mode.

@tzarebczan tzarebczan reopened this May 2, 2018
@tzarebczan tzarebczan added redesign priority: blocker Issue is blocking release, do ASAP and removed needs: triage labels May 2, 2018
@btzr-io btzr-io self-assigned this May 6, 2018
@btzr-io btzr-io mentioned this issue May 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@btzr-io btzr-io

@neb-b neb-b

Labels
priority: blocker Issue is blocking release, do ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't allow automatic night mode when dark theme is selected lbryio/lbry-desktop
5 participants
@kauffj @tzarebczan @btzr-io @neb-b @lbry-bot