Merged IBPSA, issue1556_filePermissions and issue1109_wetCoilEpsNTU #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buildings/Resources/Scripts/Dymola/Fluid/HeatExchangers/Validation/WetCoilEffectivenessNTU.mos
Show resolved
Hide resolved
…g/modelica-buildings into IBPSASync_issue1109_wetCoilEpsNTU
AntoineGautier
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges IBPSA
issue1556_filePermissionsandissue1109_wetCoilEpsNTU.(Note that
issue1556_filePermissionsis about to be merged through #2779)@AntoineGautier : Can you please make sure the changes from
issue1109_wetCoilEpsNTUare correct. The changes are from ibpsa/modelica-ibpsa#1549 which diverged from what is on the master of the Buildings library.