Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wet coil epsilon-NTU model #2364

Merged
merged 77 commits into from
Apr 20, 2021
Merged
Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
b83f96a
Checkout files from issue622_wet_coil_refactor_3
AntoineGautier Feb 10, 2021
91d2753
Run write_package_order
AntoineGautier Feb 10, 2021
cdb7778
Rename classes, refactor example and validation
AntoineGautier Feb 10, 2021
4c95298
Delete sigmoid (not used)
AntoineGautier Feb 10, 2021
87fa3f7
Update doc and description strings [ci skip]
AntoineGautier Feb 12, 2021
8fe9065
Add dry fraction
AntoineGautier Feb 12, 2021
640f071
Update original example with 30 HX elements
AntoineGautier Feb 12, 2021
be32ece
Update experiment and mos
AntoineGautier Feb 12, 2021
c5cbf6f
'Merge branch 'master' of https://github.com/lbl-srg/modelica-buildin…
AntoineGautier Feb 12, 2021
f10afdd
Fix html
AntoineGautier Feb 12, 2021
ea8100e
Fix class name
AntoineGautier Feb 12, 2021
9d53000
Update mos and results
AntoineGautier Feb 12, 2021
e520b86
Rename example, update doc
AntoineGautier Feb 12, 2021
dde6b12
Fix typos and truncate lines at 80 characters
AntoineGautier Feb 12, 2021
335a386
Update mos and results
AntoineGautier Feb 12, 2021
33802cc
Merge branch 'master' of https://github.com/lbl-srg/modelica-building…
AntoineGautier Feb 12, 2021
b45c948
Clean validation
AntoineGautier Feb 12, 2021
060bc05
Rename variable dryFra
AntoineGautier Feb 12, 2021
b0d3460
Update mos and results
AntoineGautier Feb 12, 2021
3041cdc
Configure model in steady-state for validation
AntoineGautier Feb 13, 2021
c4e613d
Add RH in validation, plus small fixes
AntoineGautier Feb 13, 2021
a0b9d71
Replace <br> with <br/>
AntoineGautier Feb 13, 2021
acdb827
Added a WetCoil model using rated condition
kim1077 Feb 14, 2021
ee6f87f
update of some descriptions
kim1077 Feb 16, 2021
d529098
Refactor with use_UA_nominal
AntoineGautier Feb 17, 2021
da34364
Update mos and results
AntoineGautier Feb 17, 2021
b72cc08
Fix medium declaration
AntoineGautier Feb 17, 2021
6beb8cd
Fixe package order
AntoineGautier Feb 17, 2021
192fb54
Update results (in progress)
AntoineGautier Feb 17, 2021
da7f802
Update results
AntoineGautier Feb 17, 2021
ca82c81
revised comment
kim1077 Feb 19, 2021
b031a0d
humidity ratio was replaced with mass fraction in the base classes
kim1077 Feb 19, 2021
cf501d3
Update doc, limit line to 80 characters
AntoineGautier Feb 22, 2021
98abe1e
Doc
AntoineGautier Feb 22, 2021
3a98f31
Update mos and results
AntoineGautier Feb 22, 2021
8d9ba49
Merge branch 'master' of github.com:lbl-srg/modelica-buildings into i…
AntoineGautier Feb 22, 2021
8c93922
Added start value to avoid warning in Optimica as w_a2_nominal is an …
mwetter Mar 10, 2021
fedf987
Revised info section, removed wrong __Dymola_Commands
mwetter Mar 10, 2021
80cc365
Merge branch 'master' into issue622_wetCoil
mwetter Mar 10, 2021
038da33
Reverted addition of dryFra
mwetter Mar 10, 2021
9fa4527
Reformatted file
mwetter Mar 10, 2021
3b9584a
Revised documentation
mwetter Mar 10, 2021
5055e39
Disabled flow reversal
mwetter Mar 10, 2021
83ed338
Corrected capitalization of instance name
mwetter Mar 10, 2021
141c20d
Checked out reference result from master
mwetter Mar 10, 2021
6ea90ef
Reset nEle
mwetter Mar 10, 2021
8c3b73f
Reset nEle
mwetter Mar 10, 2021
f6364f5
Removed storing protected variables
mwetter Mar 10, 2021
f4ac9dd
Reverted to master
mwetter Mar 10, 2021
4e5bbf0
Set cpEff to 0 rather than infinity
mwetter Mar 10, 2021
cbcd838
Simplfied assertion and added component name
mwetter Mar 10, 2021
d71deea
Revised documentation
mwetter Mar 10, 2021
cc8853f
Updated documentation to give better guidance
mwetter Mar 10, 2021
a3e7384
Added new cooling coil to tutorial
mwetter Mar 10, 2021
9229e68
revised according to Michael's comments
kim1077 Mar 15, 2021
11cb346
Rewrote to make it easier to read
mwetter Mar 23, 2021
d923952
Revised variable names
mwetter Mar 23, 2021
403b177
Removed setting parameters to their defaults
mwetter Mar 23, 2021
d81206f
Made parameter assignment final in local instance
mwetter Mar 23, 2021
77f4939
Corrected variable capitalization
mwetter Mar 23, 2021
fa199e3
Improve assert statement
AntoineGautier Mar 24, 2021
226238a
Update validation model
AntoineGautier Mar 26, 2021
5756405
Added dryFra as a public variable
mwetter Mar 26, 2021
c4bc608
Update experiment
AntoineGautier Mar 26, 2021
3c81ab8
Add validation in heating
AntoineGautier Mar 26, 2021
21a91b6
Fix wrong assignment
AntoineGautier Mar 26, 2021
efe1e6e
Merge branch 'issue622_wetCoil_dryFra_public' of github.com:lbl-srg/m…
AntoineGautier Mar 26, 2021
b3b9759
Update mos and results with dry fraction
AntoineGautier Mar 26, 2021
c779fe2
added an assertion statement checking valididity of rated condition
kim1077 Apr 5, 2021
729efa9
Merge branch 'master' of github.com:lbl-srg/modelica-buildings into i…
AntoineGautier Apr 6, 2021
7748473
Refactor with use_Q_flow_nominal
AntoineGautier Apr 7, 2021
c9b4745
Compute cp from entering fluid, update results
AntoineGautier Apr 14, 2021
6de1645
Merge branch 'master' of github.com:lbl-srg/modelica-buildings into i…
AntoineGautier Apr 15, 2021
359e729
Update parameter binding
AntoineGautier Apr 16, 2021
15a467c
Update results
AntoineGautier Apr 17, 2021
9dc4cc1
Updated release notes for new cooling coil model
mwetter Apr 19, 2021
7776009
Merge branch 'master' into issue622_wetCoil
mwetter Apr 19, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 95 additions & 0 deletions Buildings/Fluid/HeatExchangers/BaseClasses/WetCoilDryRegime.mo
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
within Buildings.Fluid.HeatExchangers.BaseClasses;
model WetCoilDryRegime "Fully dry coil model"
AntoineGautier marked this conversation as resolved.
Show resolved Hide resolved

// - water
input Modelica.SIunits.ThermalConductance UAWat
"UA for water side";
input Modelica.SIunits.MassFlowRate mWat_flow
"Mass flow rate for water";
input Modelica.SIunits.MassFlowRate mWatNonZer_flow(min=Modelica.Constants.eps)
"Mass flow rate for water, bounded away from zero";

input Modelica.SIunits.SpecificHeatCapacity cpWat
"Specific heat capacity of water";
input Modelica.SIunits.Temperature TWatIn
"Water temperature at inlet";
// -- air
input Modelica.SIunits.ThermalConductance UAAir
"UA for air side";
input Modelica.SIunits.MassFlowRate mAir_flow(min=Modelica.Constants.eps)
"Mass flow rate of air";
input Modelica.SIunits.MassFlowRate mAirNonZer_flow(min=Modelica.Constants.eps)
"Mass flow rate for air, bounded away from zero";
input Modelica.SIunits.SpecificHeatCapacity cpAir
"Specific heat capacity of moist air at constant pressure";
input Modelica.SIunits.Temperature TAirIn
"Temperature of air at inlet";
// -- misc.
input Buildings.Fluid.Types.HeatExchangerFlowRegime cfg
"The flow regime of the heat exchanger";
input Modelica.SIunits.MassFlowRate mAir_flow_nominal;
input Modelica.SIunits.MassFlowRate mWat_flow_nominal;
parameter Real delta = 1E-3 "Small value used for smoothing";
output Modelica.SIunits.HeatFlowRate QTot_flow
"Heat transferred from water to air";
output Modelica.SIunits.Temperature TWatOut
"Temperature of water at outlet";
output Modelica.SIunits.Temperature TAirOut
"Temperature of air at the outlet";
output Real eps(min=0, max=1, unit="1")
"Effectiveness for heat exchanger";
Modelica.SIunits.ThermalConductance CWat_flow=mWat_flow*cpWat
"Capacitance rate of water";
Modelica.SIunits.ThermalConductance CAir_flow=mAir_flow*cpAir
"Capacitance rate of air";
Modelica.SIunits.ThermalConductance CMin_flow_nominal=
min(mAir_flow_nominal*cpAir,mWat_flow_nominal*cpWat)
"Minimum capacity rate";
Modelica.SIunits.ThermalConductance CMax_flow_nominal=
max(mAir_flow_nominal*cpAir,mWat_flow_nominal*cpWat)
"Maximum capacity rate";
Modelica.SIunits.ThermalConductance CMin_flow=
Buildings.Utilities.Math.Functions.smoothMin(
x1=CAir_flow,x2=CWat_flow,deltaX=1E-3*(CMax_flow_nominal-CMin_flow_nominal))
"Minimum capacity rate";
Modelica.SIunits.ThermalConductance UA
"Overall heat transfer coefficient";
output Modelica.SIunits.Temperature TSurAirOut
"Surface Temperature at air outlet";
equation
UA = 1/ (1 / UAAir + 1 / UAWat)
"UA is for the overall coil (i.e., both sides)";

eps=epsilon_C(
UA=UA,
C1_flow=CWat_flow,
C2_flow=CAir_flow,
flowRegime=Integer(cfg),
CMin_flow_nominal= CMin_flow_nominal,
CMax_flow_nominal=CMax_flow_nominal,
delta= delta);

QTot_flow = eps*CMin_flow*(TAirIn-TWatIn);
TAirOut=TAirIn-QTot_flow/(mAirNonZer_flow*cpAir);
TWatOut=TWatIn+QTot_flow/(mWatNonZer_flow*cpWat);

(TAirOut-TSurAirOut)*UAAir=(TSurAirOut-TWatIn)*UAWat;

annotation (Icon(coordinateSystem(preserveAspectRatio=false), graphics={
Rectangle(
extent={{-100,100},{100,-100}},
lineColor={28,108,200},
fillColor={255,213,170},
fillPattern=FillPattern.Solid)}), Diagram(
coordinateSystem(preserveAspectRatio=false)),
Documentation(revisions="<html>
<ul>
<li>Jan 21, 2021, by Donghun Kim:<br>First implementation of the fuzzy model.
See <a href=\"https://github.com/lbl-srg/modelica-buildings/issues/622\">issue 622</a>
for more information.</li>
</ul>
</html>", info="<html>
<p>This model implements the calculation for a 100% dry coil. </p>
<p>See Buildings.Fluid.HeatExchangers.DryCoilEffectivenessNTU for documentation. </p>
</html>"));
end WetCoilDryRegime;
Loading