-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wet coil epsilon-NTU model #2364
Conversation
… into issue622_wetCoil
…into issue622_wetCoil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kim1077 See my comments. The main one is the refactoring that I think is required to get rid of a lot of duplicated code from existing classes, which will make the model maintenance really cumbersome.
Buildings/Fluid/HeatExchangers/BaseClasses/WetCoilDryWetRegime.mo
Outdated
Show resolved
Hide resolved
Buildings/Fluid/HeatExchangers/Examples/WetCoilCounterFlowMassFlow.mo
Outdated
Show resolved
Hide resolved
Buildings/Fluid/HeatExchangers/Validation/WetCoilEffectivenessNTU.mo
Outdated
Show resolved
Hide resolved
Buildings/Fluid/HeatExchangers/Validation/WetCoilEffectivenessNTU.mo
Outdated
Show resolved
Hide resolved
Buildings/Fluid/HeatExchangers/Validation/WetCoilEffectivenessNTU.mo
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kim1077 I refactored to conditionally include UA_nominal
computation. Please see the couple comments I have on the newly added classes.
Buildings/Fluid/HeatExchangers/Validation/WetCoilEffectivenessNTU.mo
Outdated
Show resolved
Hide resolved
old_StoreProtectedVariables = Advanced.StoreProtectedVariables; | ||
Advanced.StoreProtectedVariables = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mwetter This was needed to plot the dry fraction hexWetNTU.dryWetCalcs.dryFra
and illustrate that the validation case covers all the conditions from fully dry to fully wet (and originally to compare with the dry fraction computed by WetCoilCounterFlow
but I see you removed that addition as it triggered an event).
Even if it is not used for validation any more, I think plotting hexWetNTU.dryWetCalcs.dryFra
still makes sense to illustrate what the validation case covers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AntoineGautier : Please see #2417
…odelica-buildings into issue622_wetCoil
T_a2_nominal is removed as it is not needed.
TODO before merging: investigate the issue in
Setting |
This is a workaround for a bug in Dymola, see #622 (comment)
This is ready to merge when all tests pass. |
The feature branch was created based on what is described in #2001 (comment).
TODO before merging:
Buildings.Fluid.HeatExchangers.WetCoilEffectivenessNTUWithRated
. @AntoineGautier to refactor withinWetCoilEffectivenessNTU
.