Issue622 wet coil refactor 3 #2001

AntoineGautier · 2020-06-11T09:44:20Z

I create this draft PR to enable inline comments on the code.

These contain a fuzzy logic cooling coil model to handle mode changes between fully wet, fully dry and partially wet/dry. These are based on the wet coil (eps-NTU) model developed by Michael Okeef, but the following modifications were made. 1) Equations of the previous wet coil model were modified to consider when water flow rate goes to zero, 2) Equations of the previous dry coil model were modified, and 3) fuzzy logics were added to smoothen the discontinuity during mode changes.

…between Antoine and Donghun

…into issue622_wet_coil_refactor_3

Fix what might be an encoding issue.

…into issue622_wet_coil_refactor_3 [ci skip]

-- dry coil with two gains -- wet coil with one gain -- partially wet with an iteration parameter

AntoineGautier · 2020-06-11T17:51:49Z

TODO

Propagate allowFlowReversal{1, 2} to heaCoo and heaCooHum_u
Fix the issue in Buildings.Fluid.HeatExchangers.Examples.WetCoilEffectivenessNTU that exhibits convergence issues if allowFlowReversal1=true.

And update them with last version of wet coil model.

…into issue622_wet_coil_refactor_3 [ci skip]

…rence.

…into issue622_wet_coil_refactor_3

…odels

AntoineGautier · 2020-11-06T20:36:43Z

@kim1077 I just committed the version with the IBPSA wet coil model (from ibpsa/modelica-ibpsa#1113). The example and validation models have also been refactored. I will focus on benchmarking the simulation performance on large models. I let you go ahead with benchmarking the model precision.

…into issue622_wet_coil_refactor_3

…ore simpler and reliable.

…_wet_coil_refactor_3

1. Devision by zero has regularized with nonZeroPower (on both fully wet coil model and the highest model) 2. The issue of Cpeff (~derivate of satruated water enthaly) at Twatin=Twatout was treated strictly. 3. Enforced Qtot =0 whenever m is near zero.

Some bugs e.g. r != 2/3 for Fuzzy, FVM elements =4 etc have been modified.

…into issue622_wet_coil_refactor_3

… initial equation

Buildings/Fluid/HeatExchangers/BaseClasses/DryCalcsFuzzy_V2_2.mo

Buildings/Fluid/HeatExchangers/BaseClasses/ParcalcsFuzzy_V2_2.mo

AntoineGautier · 2021-02-10T00:46:35Z

@kim1077 I propose to close this PR without merging and open a new one with the branch issue622_wetCoil that I just created with the following steps:

Merge the master 3c2d297 into issue622_wet_coil_refactor_3 456406e
From the master 3c2d297 git checkout -b issue622_wetCoil
git diff issue622_wet_coil_refactor_3 --name-only > ~/tmp.txt
Manually edit ~/tmp.txt to remove all unnecessary modifications. The resulting file is attached for reference.
git checkout issue622_wet_coil_refactor_3 -- $(cat ~/tmp.txt)
Run buildingspy.development.refactor.write_package_order(directory=".", recursive=True) from Python shell.
Rename classes, especially WetEffectivenessNTU_Fuzzy_V3 is now WetCoilEffectivenessNTU.
Delete sigmoid.mo which is not used.

I removed all other versions of the model and the whole Buildings.Fluid.HeatExchangers.H_Example package.
Can you please double check the version that is now on issue622_wetCoil because I have some doubts that it is indeed the last version you worked on. Indeed, when I first tried to run Buildings.Fluid.HeatExchangers.Examples.WetCoilEffectivenessNTU I got the following error (which is fixed now with my last commit cdb7778). Also the UA_nominal computation is not included but that might be OK for now.

Class or component 'TWatOut_init' not found in WetEffectivenessNTU_Fuzzy_V3 hex

After your confirmation I will move forward with reviewing the code on issue622_wetCoil.

tmp.txt

AntoineGautier · 2021-02-10T00:48:21Z

@mwetter Can we delete the following branches?
issue622_wet_coil_refactor_3
issue622_wet_coil_refactor_2
issue622_wet_coil

The development will be merged through the new branch issue622_wetCoil.

AntoineGautier · 2021-02-11T22:57:22Z

This is closed without merging.
The development will be merged through the new branch issue622_wetCoil.

kim1077 and others added 18 commits April 13, 2020 16:01

Add sigmoid function

5e92e4f

Fuzzy Condensing Cooling Coil Model Development, Internal iterations …

1810956

…between Antoine and Donghun

Fuzzy model edited

7ecdb42

Travis editted

06d3132

Merge branch 'master' of https://github.com/lbl-srg/modelica-buildings …

5aa1338

…into issue622_wet_coil_refactor_3

Checkout package.order from master

429556c

Fix what might be an encoding issue.

Fix typo

14f7839

Format

d0e2a21

Update validation cases and scripts

da2cb69

Merge branch 'master' of https://github.com/lbl-srg/modelica-buildings …

e07f48d

…into issue622_wet_coil_refactor_3 [ci skip]

Update script with standard simulation parameters [ci skip]

dde2126

Update scripts

906f456

Update validation models and scripts

b6a9acd

Dummy commit [ci skip]

7a37f27

Update scripts [ci skip]

c3cf263

dummy

34cc92a

-- unnecessary partially wet coil iteration is avoided.

e564ce8

-- dry coil with two gains -- wet coil with one gain -- partially wet with an iteration parameter

AntoineGautier and others added 8 commits June 11, 2020 10:53

Rename example and validation models [ci skip]

024be33

And update them with last version of wet coil model.

Merge branch 'master' of https://github.com/lbl-srg/modelica-buildings …

00c17d6

…into issue622_wet_coil_refactor_3 [ci skip]

Merge branch 'master' of https://github.com/lbl-srg/modelica-buildings …

5aa53e2

…into issue622_wet_coil_refactor_3 [ci skip]

Trial to prevent small mass flow rate & updated e-NTU wetcoil model.

83687ed

Added a validation file which compares the wet coil model with a refe…

28d589e

…rence.

Treatment of IC

7684dc7

Merge branch 'master' of https://github.com/lbl-srg/modelica-buildings …

7d93caf

…into issue622_wet_coil_refactor_3

Merge branch with IBPSA model and refactored example and validation m…

951f285

…odels

AntoineGautier added 2 commits November 9, 2020 16:29

Add test models in Experimental.DHC.Loads

b961181

Update and add simulation scripts

455dc84

AntoineGautier and others added 20 commits November 21, 2020 11:43

Add dry fraction comparison

d407cd1

Merge branch 'master' of https://github.com/lbl-srg/modelica-buildings …

f2bb144

…into issue622_wet_coil_refactor_3

Fuzzy model has been updated from V2.2.2 to V3 which is numerically m…

847047b

…ore simpler and reliable.

Merge branch 'issue622_wet_coil_refactor_3_simplefuzzy' into issue622…

7789127

…_wet_coil_refactor_3

Update with WetEffectivenessNTU_Fuzzy_V3

7fad65f

Key updates:

80f51db

1. Devision by zero has regularized with nonZeroPower (on both fully wet coil model and the highest model) 2. The issue of Cpeff (~derivate of satruated water enthaly) at Twatin=Twatout was treated strictly. 3. Enforced Qtot =0 whenever m is near zero.

Initial code for extracting nominal UA from data.

ec79926

Some bugs e.g. r != 2/3 for Fuzzy, FVM elements =4 etc have been modified.

equations for calculating UAnominal & wetfuzzy3 updates using smoothemax

c159d93

Merge branch 'master' of https://github.com/lbl-srg/modelica-buildings …

c4254a5

…into issue622_wet_coil_refactor_3

Add VAV models

3ed1a3b

Update validation models

1f86570

Clean model

8c357ba

Clean the code

9c042b7

docummentation of the fuzzy model

23e5223

retreiving UA value via LMED

cc4cba0

eliminate iteration via a virtual dynamics

59436a6

UA_nominal estimation error is below 0.2%, wAirOut is now a variable,…

84e40ec

… initial equation

development branch not for distribution

7f75746

nomenclature updated

5d234da

documentation for the fuzzy cooling coil model

456406e

bravache linked an issue Feb 2, 2021 that may be closed by this pull request

Refactor Examples.VAVReheat.ThermalZones.VAVBranch and VAV models to expose the coil sizing parameters #2059

Closed

AntoineGautier commented Feb 10, 2021

View reviewed changes

AntoineGautier closed this Feb 11, 2021

AntoineGautier deleted the issue622_wet_coil_refactor_3 branch February 11, 2021 22:57

AntoineGautier mentioned this pull request Feb 11, 2021

Wet coil epsilon-NTU model #2364

Merged

2 tasks

AntoineGautier restored the issue622_wet_coil_refactor_3 branch February 12, 2021 22:39

AntoineGautier deleted the issue622_wet_coil_refactor_3 branch January 29, 2022 15:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue622 wet coil refactor 3 #2001

Issue622 wet coil refactor 3 #2001

AntoineGautier commented Jun 11, 2020 •

edited

Loading

AntoineGautier commented Jun 11, 2020

AntoineGautier commented Nov 6, 2020

AntoineGautier commented Feb 10, 2021 •

edited

Loading

AntoineGautier commented Feb 10, 2021

AntoineGautier commented Feb 11, 2021

Issue622 wet coil refactor 3 #2001

Issue622 wet coil refactor 3 #2001

Conversation

AntoineGautier commented Jun 11, 2020 • edited Loading

AntoineGautier commented Jun 11, 2020

AntoineGautier commented Nov 6, 2020

AntoineGautier commented Feb 10, 2021 • edited Loading

AntoineGautier commented Feb 10, 2021

AntoineGautier commented Feb 11, 2021

AntoineGautier commented Jun 11, 2020 •

edited

Loading

AntoineGautier commented Feb 10, 2021 •

edited

Loading