Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API call for CSR #1

Open
lawndoc opened this issue Aug 11, 2021 · 2 comments
Open

Add API call for CSR #1

lawndoc opened this issue Aug 11, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@lawndoc
Copy link
Owner

lawndoc commented Aug 11, 2021

Create an API call that can accept PEM encoded CSR and Public Key and generate a certificate based on that.

We'll need to use cryptography.x509.load_pem_x509_csr() to convert the PEM encoded CSR to a csr object that ownca can recognize.

@lawndoc lawndoc self-assigned this Aug 11, 2021
@lawndoc lawndoc added enhancement New feature or request good first issue Good for newcomers labels Aug 11, 2021
@lawndoc
Copy link
Owner Author

lawndoc commented Aug 11, 2021

The ownca method corresponding to this functionality is ownca.ownca.CertificateAuthority.sign_csr()

@lawndoc
Copy link
Owner Author

lawndoc commented Aug 11, 2021

I think it would also be a good idea to support DER encoding as well. cryptography.x509.load_der_x509_csr() is the DER counterpart to the method in my initial comment. It shouldn't be too hard to detect which was sent once it's received.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant