Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation messages not shown #179

Closed
PabloKowalczyk opened this issue Jan 6, 2019 · 1 comment
Closed

Deprecation messages not shown #179

PabloKowalczyk opened this issue Jan 6, 2019 · 1 comment
Labels

Comments

@PabloKowalczyk
Copy link
Collaborator

Crunz version: 1.10.0

PHP version: 5.6

Operating system type and version: Alpine linux 3.8

Description
Deprecations triggered in \Crunz\Configuration\ConfigurationParser (probably in other classes too) are not handled by handler registered in \Crunz\Application::registerDeprecationHandler.

How to reproduce

Trigger deprecation in \Crunz\Configuration\ConfigurationParser::parseConfig method:

@\trigger_error("Test deprecation", E_USER_DEPRECATED);

Possible Solution

Try to call registerDeprecationHandler earlier, ideally just after container initialization.

Additional context

@PabloKowalczyk
Copy link
Collaborator Author

Fixed in #180.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant