Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to change lock directory #125

Closed
IkeLutra opened this issue Jul 10, 2018 · 2 comments
Closed

Ability to change lock directory #125

IkeLutra opened this issue Jul 10, 2018 · 2 comments

Comments

@IkeLutra
Copy link

Scenario

Running crunz in docker containers but still wanting to use the preventOverlapping feature using a shared volume.

Current Behaviour

Crunz always uses the system temp directory. It also requires on POSIX systems for all crunz jobs to be running in the same execution environment as it checks whether the pid in that file is still running. This prevents using shared file systems but different execution environments.

Proposed Behaviour

No changes to the defaults but adding the ability to change the lock directory and disable the checking of pids (e.g. drop to windows file only mode).

I have made a first attempt at this on this fork: AgePartnership@0a45f0a

Let me know your thoughts?

@PabloKowalczyk
Copy link
Collaborator

Hello, thanks for issue @IkeLutra.
I like your idea, i even thought about adding symfony/lock component and support other backends such as Redis or memcached, but this need much more work and will be added to v2 of Crunz (probably :).
PR is very welcome, please remember to have v1 as a base branch and v1 as a target brach.
Thanks.

@PabloKowalczyk
Copy link
Collaborator

Implemented in #153 and merged. Thanks @IkeLutra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants