Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type declarations are not published to npm registry #1

Open
kuskoman opened this issue May 8, 2020 · 4 comments
Open

Type declarations are not published to npm registry #1

kuskoman opened this issue May 8, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@kuskoman
Copy link

kuskoman commented May 8, 2020

The library is not emitting type declarations so it's kind of useless when used with TypeScript in strict mode

@appellation appellation added the bug Something isn't working label May 8, 2020
@appellation
Copy link
Member

Good catch! You're welcome to open a PR for a fix or we'll get to it eventually.

@kuskoman
Copy link
Author

kuskoman commented May 8, 2020

As I guess it's caused by gulp, which I think is useless in these times since you are able to build files just using typescripts tsc command.
If you agree with me I will prepare PR replacing gulp with typescript compiler and modify its (typescripts) config

@appellation
Copy link
Member

Sounds great. I don't recall why we used Gulp, but using plain TSC is definitely preferred here for such a simple build process.

@kuskoman kuskoman mentioned this issue May 8, 2020
@DevYukine
Copy link
Contributor

Hey thanks for the information but you are kinda wrong, its not that i dont emit type declarations but somehow npm didn't upload them, locally i have them as expected so the PR (#2) is also kinda pointless to me, i will release a new minor later today with type declarations as expected ^^.

For why i used Gulp is just convenience so i dont mind you removing/replacing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants